252618 - Live theme switching: "Apply theme" menu broken

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

ok, I played around with this a bit, in seamonkey

step 1: re-enable it live theme switching (I'll attach the patch to do that)

step 2: View|Apply theme|modern

Now, in this window, you can not get the apply theme submenu anymore. nothing
happens when hovering over it.

This works fine in new windows; but in the old window, it's still broken after
switching back to classic in a new window (not surprising).

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch to enable live theme switch (DO NOT CHECK IN)

Comment 2

[[e-mail]]

For whatever reason submenus rely on setting the "open" attribute to open them.
No code that I know of actually depends on this, but there you go...

So of course submenus need the "open" attributes removed when you close them.
But switching themes forcibly destroys all menu frames. This makes the menus
think that the document has been deleted and don't bother removing attributes.

If you go into DOMI you'll see the "open" attribute on that submenu, and you can
safely delete it and go back into View/Apply again.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Should the frame destructors unset the open attributes?

Comment 4

[Alfred Kayser]

The patch is for navigator.js, which is only valid for SeaMonkey (nowadays).
Apply Theme works in SeaMonkey (but requires a restart, but that is a separate issue).

Comment 5

[[e-mail]]

Correct resolution, but entirely wrong reason.

Live theme switching from the Apply Theme menu was fixed as part of the switch to toolkit, although you have to turn on the preference in the Debug pane.

The bug about not being able to reopen the menu was fixed by bug 282359.