252720 - nsFileStream::InitWithFileDescriptor looks like a permanent cycle

Status: RESOLVED INVALID

(Core :: XPCOM, defect, P5)

Description

[timeless]

nsFileStream::InitWithFileDescriptor(PRFileDesc* fd, nsISupports* parent)
{
    NS_ENSURE_TRUE(mFD == nsnull, NS_ERROR_ALREADY_INITIALIZED);
...
    mParent = parent;
...
}

There is no code that I can find to clear mParent.

Comment 1

[timeless]

class nsFileStream : public nsISeekableStream
{
...
protected:
    nsCOMPtr<nsISupports> mParent; // strong reference to parent nsFileIO,
                                   // which ensures mFD remains valid.
...
}

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

ok, where's the other part of the cycle? I can't find a place where this code
makes mParent reference the child. So, the dtor will release the parent.

(I also can't find a caller of this function...)