Shows how often this bit of the code gets called! I've added the parentheses to the relevant line and used my editor to automatically remove all trailing whitespace in the upcoming patch (no other changes).
Wanna attach a diff -w version here for reviewers only?
Comment on attachment 154067 [details] [diff] [review] cvs diff -w - nsCOMPtr<nsIDOMWindowInternal> domwin(do_QueryInterface(doc->GetScriptGlobalObject)); + nsCOMPtr<nsIDOMWindowInternal> domwin(do_QueryInterface(doc->GetScriptGlobalObject())); Wow, I bet this wouldn't even compile... this code is inside an #ifdef DEBUG_DOCSHELL_FOCUS, which I guess noone really defines any more... r+sr=jst for this and all the cleanup you did.
Thanks for the super fast review. Maybe the DEBUG_DOCSHELL_FOCUS stuff should just be removed, it only appears in content/events/src/nsEventStateManager.cpp and docshell/base/nsDocShell.cpp
given that problems do happen near that stuff, we should probably resurrect it instead.
Comment on attachment 154066 [details] [diff] [review] patch this sr request seems obsolete now...
This patch makes it amazingly more difficult for me to get my changes in bug 250006 to merge in.
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.