Add call parentheses to GetScriptGlobalObject and remove trailing whitespace in nsEventStateManager.cpp

RESOLVED FIXED

Status

()

Core
DOM
RESOLVED FIXED
14 years ago
14 years ago

People

(Reporter: jwatt, Assigned: jwatt)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments)

(Assignee)

Description

14 years ago
Shows how often this bit of the code gets called! I've added the parentheses to
the relevant line and used my editor to automatically remove all trailing
whitespace in the upcoming patch (no other changes).
(Assignee)

Comment 1

14 years ago
Created attachment 154066 [details] [diff] [review]
patch
(Assignee)

Updated

14 years ago
Attachment #154066 - Flags: superreview?(jst)
Wanna attach a diff -w version here for reviewers only?
(Assignee)

Comment 3

14 years ago
Created attachment 154067 [details] [diff] [review]
cvs diff -w
Comment on attachment 154067 [details] [diff] [review]
cvs diff -w

-  nsCOMPtr<nsIDOMWindowInternal>
domwin(do_QueryInterface(doc->GetScriptGlobalObject));
+  nsCOMPtr<nsIDOMWindowInternal>
domwin(do_QueryInterface(doc->GetScriptGlobalObject()));

Wow, I bet this wouldn't even compile... this code is inside an #ifdef
DEBUG_DOCSHELL_FOCUS, which I guess noone really defines any more...

r+sr=jst for this and all the cleanup you did.
Attachment #154067 - Flags: superreview+
Attachment #154067 - Flags: review+
(Assignee)

Comment 5

14 years ago
Thanks for the super fast review. Maybe the DEBUG_DOCSHELL_FOCUS stuff should
just be removed, it only appears in content/events/src/nsEventStateManager.cpp
and docshell/base/nsDocShell.cpp

Comment 6

14 years ago
given that problems do happen near that stuff, we should probably resurrect it 
instead.
Comment on attachment 154066 [details] [diff] [review]
patch

this sr request seems obsolete now...
Attachment #154066 - Flags: superreview?(jst)

Comment 8

14 years ago
This patch makes it amazingly more difficult for me to get my changes in bug
250006 to merge in.
(Assignee)

Updated

14 years ago
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.