252744 - Find Toolbar doesn't work when typing non-english letters with FAYT enabled

Status: RESOLVED DUPLICATE of bug 251891

(Toolkit :: Find Toolbar, defect)

Description

[Ivan Sagalaev]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040722 Firefox/0.9.1+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040722 Firefox/0.9.1+

1. Typing non-english (russian - if it matters) letters with enabled FAYT
doesn't activates Find Toolbar at all. Searching is also not conducted.
2. Typing '/' (which is in fact '.' in russian keyboard layout) does activate
Find Toolbar with a character '.' in it but following letters don't show up and
search also is not conducted.
3. However, typing Ctrl+F does activate Find Toolbar, empty, focused and allows
typing following russian letters and conducts search as well.

Reproducible: Always
Steps to Reproduce:

Comment 1

[Peter van der Woude [:Peter6]]

this is definitly a dupe, but i can't find of which bug

Comment 2

[Peter van der Woude [:Peter6]]

found it ;-)

*** This bug has been marked as a duplicate of 251891 ***

Comment 3

[Nickolay_Ponomarev]

It's not a dupe. Bug 251891 is about Find Toolbar not working in general with
non-english characters. Half of comments is WFM there, and that works for me too
if that matters.

This bug is about another issue - entering russian characters when content area,
not FT is active does nothing - keyhits don't get passed to FT. It is more
related to bug 250751, but not a dupe either.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040724
Firefox/0.9.1+ (typing russian chars too)

Comment 4

[Peter van der Woude [:Peter6]]

Reopened on request by last commenter

Comment 5

[Legenda]

It seems that currently the find engine as a whole is experiencing difficulties.
Try if you can enter cyrillic characters after opening the find toolbar with Ctrl+F.

Wheter or not FAYT is enabled seems to be meaningless. IMHO bugs 251891 and
252744 discuss the same issue. 

Comment 6

[Nickolay_Ponomarev]

There are two different issues with the new Find Toolbar:
1) Bug 251891 - Find Toolbar does not work with some characters AT ALL. See bug
251891 comment 15 or original report for example.
2) This bug - Find Toolbar DOES work with cyrillic chars, but not when the
content area 
has focus. (see also bug 251891 comment 16).

Actually, *this* bug is caused by using isPrintable(evt.charCode) in browser.js,
Ln352: isPrintable() returns false on cyrillic chars, so FAYT is not activated.

Comment 7

[Jon Henry]

I think Blake may have fixed this with a checkin tonight, could someone who
experiences the bug try out tomorrow's nightly build and see how it goes?

Comment 8

[Nickolay_Ponomarev]

As I can judge from the code, this will be fixed, but the checkin causes severe
regressions as described in bug 251891 comment 21, so the bug needs further work.

Comment 9

[Asaf Romano (gone)]

This was the same bug...

*** This bug has been marked as a duplicate of 251891 ***