252755 - Tidy nsIDOMClassInfo.h and nsDOMClassInfo.cpp

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Jonathan Watt [:jwatt]]

Bug for putting the SVG parts of these two files in alphabetical order and
removing trailing whitespace from all lines in the files.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: diff using -w for reviewers

Comment 2

[Jonathan Watt [:jwatt]]

Attachment: patch for checking in (whitespace tidied)

Comment 3

[Jonathan Watt [:jwatt]]

Attachment: patch without whitespace changes

I've been asked not to make massive changes to whitespace for its own sake, so
here's a new patch without the ws changes.

Comment 4

[Jonathan Watt [:jwatt]]

jst, bz has pointed out
http://lxr.mozilla.org/seamonkey/source/dom/public/nsIDOMClassInfo.h#195 to me.
Is it okay to be doing this since it only applied to SVG, or will putting things
in order cause problems for anyone building/running an SVG enabled mozilla? That
comment doesn't explain why binary compatibility is desirable. 

Comment 5

[Johnny Stenback (:jst)]

Yeah, that's fine... the binary compatibility here is pretty bogus, so feel free
to move things around for SVG.

Comment 6

[Jonathan Watt [:jwatt]]

Thanks jst. 

Confirming I didn't have any problems when browsing through
croczilla.com/svg/samples. 

Comment 7

[Johnny Stenback (:jst)]

Comment on attachment 154112 [details] [diff] [review]
patch without whitespace changes

r+sr=jst

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in mozilla/dom/public/nsIDOMClassInfo.h;
/cvsroot/mozilla/dom/public/nsIDOMClassInfo.h,v  <--  nsIDOMClassInfo.h
new revision: 1.50; previous revision: 1.49
done
Checking in mozilla/dom/src/base/nsDOMClassInfo.cpp;
/cvsroot/mozilla/dom/src/base/nsDOMClassInfo.cpp,v  <--  nsDOMClassInfo.cpp
new revision: 1.226; previous revision: 1.225
done