252850 - options in some listboxes only highlighted to text width, not listbox width

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This is a regression from bug 232540.  Some options in listboxes are only
highlighted to the text width, not the listbox width.

Steps to reproduce:
 1. load http://bugzilla.mozilla.org/enter_bug.cgi?product=Browser
 2. Click on "Trunk" in the "version" listbox at the upper left.

Actual results:  Highlighting is only the width of "Trunk" with a little padding

Expected results: Highlighting should be the width of the listbox.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Strange. Most listboxes seem to work

Comment 2

[Jason Bassford]

WFM using 7/23-07 with XP.

Comment 3

[Boris Zbarsky [:bzbarsky]]

*** Bug 252932 has been marked as a duplicate of this bug. ***

Comment 4

[Frank Wein [:mcsmurf]]

Attachment: Testcase

This bug seems to occour when the entries in the listbox are exactly as high as
the listbox is. If there are fewer entries, the bug doesn't occour, when there
is a scrollbar, the bug doesn't occour.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Good catch :-)

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Okay, that checkin was wrong because it allows a reflow at unconstrained width
(to determine intrinsic width) which is not followed by any reflow at
constrained width ... this should never happen. In this case the blocks are
never given a width constraint to reflow to.

I think I should just backout that checkin. Fixing the minor underlying bug
there (which AFAIK has never been reported) can wait until I've rewritten
scrollframes to make scroll layout sane(r).

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

backing it out seems reasonable

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

okay, I backed that out.