252875 - bookmarks small ui fixups

Status: RESOLVED INVALID

(Firefox :: Bookmarks & History, defect)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

There's a few bugs floating around on related things, so I'm combining them
here.  Note that I'm just bringing up **small** fixes here; if you want a
rewritten bookmarks manager, make your own bug. :)  There's already a few bugs
filed on this stuff, but they're small, and easily dropped on the floor.

- remove New Folder/Bookmark/Separator from context menu in the Bookmarks menu.
 Leave it in the tree views (manager, sidebar), and the personal toolbar folder.
 Selecting one of these causes the menu to close up (can't do anything about
that), so you have to open the menus again to get to your new item.

- remove New Folder/Bookmark/Separator from context menu of bookmarks -- i.e.
they'd only appear if you right-clicked an actual folder, and the new item would
go into that folder.

- remove the ability to rename the top-level Bookmarks folder (you can't rename
the menu, so why rename the folder?)

- make "Add Bookmark" dialog always default to the top-level Bookmarks folder,
with the recently-used folders listed below it and a separator.  Even then, it's
not really clear that it's a list of recently-used folders; it looks more like a
jumble of 5 randomly chosen folders. (bug 232089)

- instead of the above, never make the personal toolbar folder "recently used".
 Right now, if you drag a site to the toolbar, and then later hit C-d to add a
bookmark, your most recent site defaults to the personal toolbar.

- get rid of the sidebar in the bookmarks manager.  it's a cool idea, but i'm
not sure I can fix the issues with it in time for 1.0:
 * it has issues in that it always shows +/- expanders even when there's no
sub-folders, because there are other children but they get filtered out
 * double-clicking to open one is weird, need to do it twice;
 * other strangeness (bug 252858);
 * most importantly, it has no relationship whatsoever to the actual bookmarks
manager pane: this type of two-pane view, you'd expect the right side to contain
the contents of whatever's selected in the left sidebar, or to have actions on
the left have an effect on the right, but nothing like that happens.

- if not get rid of it entirely, at least hide it by default and have a menu
option to show/hide.


any objections to these, or any suggestions to add?

Comment 1

[Ryan Polk (Quark)]

Well, this would certainly solve the dilemma holding up bug 239429.  Though as
that bug notes consistancy throughout everything (not just the sidebar) is still
an issue.

Comment 2

[Peter van der Woude [:Peter6]]

bug 251376 -Use a different icon to identify a Livemark (live bookmark) 
Providing you can find the time for it Vladimir.
It's prtty trivial but great for "looks"
I went through the rss definition to see if adding an icon from the feed itself
was optional, but unfortunately it's not.

>it has no relationship whatsoever to the actual bookmarks
>manager pane: this type of two-pane view, you'd expect the right side to contain
>the contents of whatever's selected in the left sidebar, or to have actions on
>the left have an effect on the right, but nothing like that happens.
This is bug 247960 - The 2 panes of bookmarkmanager do not interact.
There is a patch to fix the interaction , you may want to review that one
yourself (request was for Ben)

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Another:

- bug 252656, get rid of "Manage Folder".  there's no way to get to the root,
and you've still got the sidebar that doesn't function like you'd want it to --
you're already drilled into a folder, but you can't change what folder you're
drilled into.  we can change the whole thing to have a more explorer-y feel to
it, but I doubt it's 1.0 material.

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

(In reply to comment #0)
> - remove the ability to rename the top-level Bookmarks folder (you can't
rename the menu, so why rename the folder?)

bug 252881 -- we already localize this (or are allowed to); renaming it
shouldn't happen, and it was an oversight that it worked at all..

Comment 5

[Peter van der Woude [:Peter6]]

Vladimir,
was there any reason to remove the "New Livemark" button from the Bookmark
Manager , or did it slip out ?
It went mia a few days ago

Comment 6

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

(In reply to comment #5)
> Vladimir,
> was there any reason to remove the "New Livemark" button from the Bookmark
> Manager , or did it slip out ?
> It went mia a few days ago

It was removed as part of some manager cleanup; it didn't really need to be
there (I added it originally for symmetry), and just added extra clutter to the
toolbar.  You can still manually create a livemark from the menu.

Comment 7

[Žiga Sancin]

Vladimir: How about Bug 250602 ?

Comment 8

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change

Comment 9

[Shawn Wilsher :sdwilsh]

I'm gonna close this as INVALID as it's pretty useless now.  If there are existing UI issues, they should be filed as separate bugs.