Closed Bug 252950 Opened 21 years ago Closed 19 years ago

nsTextFragment inconsistent wrt the accepted charset for 1b

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: Biesinger, Unassigned)

References

Details

(Whiteboard: [good first bug])

<bz> There are two codepaths <bz> one does <bz> 140 if (IsASCII(aString)) { <bz> 131 nsTextFragment::operator=(const nsAString& aString) <bz> The other one does <bz> 185 if (ch >> 8) { <bz> 186 need2 = PR_TRUE; <bz> That's in <bz> 174 nsTextFragment::SetTo(const PRUnichar* aBuffer, PRInt32 aLength) <bz> That seems wrong to me. both codepaths should only accept ASCII.
Whiteboard: [good first bug]
Blocks: 333535
This one was fixed by bug 329974, we now always store 8-byte characters as 1b.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
That should be 8-bit characters of course.
ok. that actually made this bug WONTFIX per comment 0 though. (although it fixed the summary)
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.