nsTextFragment inconsistent wrt the accepted charset for 1b

RESOLVED FIXED

Status

()

RESOLVED FIXED
14 years ago
5 years ago

People

(Reporter: Biesinger, Unassigned)

Tracking

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug])

<bz> There are two codepaths
<bz> one does
<bz> 140     if (IsASCII(aString)) {
<bz> 131 nsTextFragment::operator=(const nsAString& aString)
<bz> The other one does
<bz> 185       if (ch >> 8) {
<bz> 186         need2 = PR_TRUE;
<bz> That's in
<bz> 174 nsTextFragment::SetTo(const PRUnichar* aBuffer, PRInt32 aLength)
<bz> That seems wrong to me.

both codepaths should only accept ASCII.
Whiteboard: [good first bug]
This one was fixed by bug 329974, we now always store 8-byte characters as 1b.
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
That should be 8-bit characters of course.
ok. that actually made this bug WONTFIX per comment 0 though. (although it fixed the summary)
You need to log in before you can comment on or make changes to this bug.