252954 - In <menulist.xml>, "Error/Exception, NS_ERROR_FAILURE, nsIMenuBoxObject.activeChild, onxblkeypress"

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8a2) Gecko/20040714] (release) (W98SE)

{{
Error: uncaught exception: [Exception... "Component returned failure code:
0x80004005 (NS_ERROR_FAILURE) [nsIMenuBoxObject.activeChild]"  nsresult:
"0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame ::
chrome://global/content/bindings/menulist.xml :: onxblkeypress :: line 41" 
data: no]
}}

This happens when leaving the To/Cc/etc dropdown listbox with the keyboard.

Reproductible: 100%
1. Ctrl-M/... to compose a new message
2. Shift-Tab to go to the listbox
3. Tab to go (back) to the addresse field
3a. Works, but error in the JS.C. :-(

This may be Browser component rather than MailNews !?

Comment 1

[Serge Gautherie (:sgautherie)]

Invalid: This seems related to my modified setup only ... sorry.

Comment 2

[Serge Gautherie (:sgautherie)]

Sorry again: the bug is there, I didn't checked the JS.C. properly in comment 1...


[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8a1) Gecko/20040520] (release) (W98SE)

But v1.8a1 does not have it: regression !

Comment 3

[Serge Gautherie (:sgautherie)]

Must I say it: sorry, I want to reopen this bug actually.
(I should really be sleeping now !)

Comment 4

[[e-mail]]

bz, my problem is that the popup frame hasn't been created yet ... I can create
it by marking the menu as generated but I seem to remember you saying I can't do
that synchronously, is that correct?

Comment 5

[Boris Zbarsky [:bzbarsky]]

So.. At least one problem is that nsBoxObject::GetFrame is buggy.  It should be
doing a Flush_Frames flush on the presshell before calling GetPrimaryFrameFor.

With that fixed, you should be able to set the attr and get to the thing through
the box object synchronously...

Comment 6

[[e-mail]]

Attachment: Proposed patch

As it turns out, it seems to work anyway...

Comment 7

[[e-mail]]

Attachment: -w

Comment 8

[Boris Zbarsky [:bzbarsky]]

For now it does.  I believe that once bug 230170 lands it will break without the
changes described in comment 5.

Comment 9

[[e-mail]]

Attachment: Take two

OK, so this time I'm bulletproofing the box object.
And I call nsMenuFrame::MarkAsGenerated, so no worries there :-)

Comment 10

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 154307 [details] [diff] [review]
Take two

r+sr=bzbarsky, though GetFrame _still_ needs fixing, in my opinion (as in, if
there is a reframe out on an event, we want to flush it out before calling
GetFrame()).

Comment 11

[[e-mail]]

Fix checked in.