Closed Bug 25303 Opened 25 years ago Closed 25 years ago

FILE/FTP dir listings broken

Categories

(Core :: Networking, defect, P1)

Product:
Core
Component:
Networking
Platform:
x86
Windows NT
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: jud, Assigned: waterson)

References

Details

(Whiteboard: [PDT+] fix ready)

Attachments

(1 file)

proposed fix
19.83 KB, patch
Details | Diff | Splinter Review 
you get two tree widgets in the window and neither fill in.
Severity: normal → blocker
looking...
Status: NEW → ASSIGNED
Priority: P3 → P1
Target Milestone: M14
lucky waterson :-)
Assignee: nobody → waterson
Status: ASSIGNED → NEW
looks like tree/table incremental reflow or crappy XUL, because the result show 
up as soon as I resize the window. hyatt! help me!
Status: NEW → ASSIGNED
Summary: FTP dir listings broken → [blocker] FTP dir listings broken
waaah! fix my crappy XUL for me hyatt.

http://lxr.mozilla.org/mozilla/source/xpfe/components/directory/directory.xul

it's not dealing with the case where content is incrementally reflowed b/c of 
async arrival.
Assignee: waterson → hyatt
Status: ASSIGNED → NEW
The XUL looks good to me.

I see this happening to the sidebar as well. The tree isn't duplicated, but it 
is truncated halfway down the screen just like the FTP dirs. Related? See bug 
25334.
Keywords: beta1
I didn't touch the tree widget code yesterday.  karnaze or troy, were any 
changes made to incremental table reflow that I don't know about?
Status: NEW → ASSIGNED
I did a checkin around 6pm but that was after the bug. Prior to that, I hadn't 
checked anything in for more than a few days due to smoke test bustage.
Yeah, I'm suspecting something random and weird... not tree or table-related.


Resize the window, and it shows up fine.  I'm removing the blocker designation, 
since that's only valid if it's preventing you from getting work done.  It 
isn't.
Summary: [blocker] FTP dir listings broken → FTP dir listings broken
changing summary from "FTP dir listings broken"
Summary: FTP dir listings broken → FILE/FTP dir listings broken
Putting on PDT+ radar for beta1.
Keywords: dogfood
Whiteboard: [PDT+]
Updating QA Contact.
Component: Browser-General → Networking
QA Contact: nobody → tever
Updating QA Contact.
*** Bug 26465 has been marked as a duplicate of this bug. ***
Letting waterson investigate notifications, and other stuff... make sure it's 
not the trees fault (or is the trees fault)....
Assignee: hyatt → waterson
Status: ASSIGNED → NEW
*** Bug 26656 has been marked as a duplicate of this bug. ***
backatcha, baby.
Assignee: waterson → hyatt
Is this bug fixed?
Status: NEW → ASSIGNED
Whiteboard: [PDT+] → [PDT+] Haven't investigated yet. Don't know what's still broken.
Sorry, I'm giving this back.  The assertion in today's build in nsIOService is 
actually helpful to me, since it indicates to me that you're not telling me any 
contents to display, e.g., when you first bring up "c:\", the tree widget is 
there but empty.  

It's obviously the right height, since the sort column goes all the way down the 
window.  If I resize the window, thereby forcing a reflow, then you go out to 
Necko and fetch data (and then I hit the nsIOService assertion).  This indicates 
to me that you didn't actually go get any data to give to the tree.

So I don't think this is a tree widget bug.  I still think it's a notification 
bug.
Assignee: hyatt → waterson
Status: ASSIGNED → NEW
BTW, the ability to follow the folders as links is preposterously sexy.
Status: NEW → ASSIGNED
The broken-ness is coming from XUL sorting. I'd put in a bunch of code to find 
the "first generated element". Unfortunately, it doesn't take into account the 
fact that the first element you create might not necessarily end up being the 
first element in the container. Zoiks!
Whiteboard: [PDT+] Haven't investigated yet. Don't know what's still broken. → [PDT+] fix ready
Attached patch proposed fix — — Splinter Review 

    
    

    
  
per hyatt's suggestion, remember the container and the index instead of the 
first node created. r=rjc. I'll check it in when the tree gets green.

    
    

    
  
fix checked in
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED

    
    

    
  
verified:
NT 2000021708
Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: