If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Fix a couple of subtle block reflow bugs

RESOLVED FIXED

Status

()

Core
Layout
RESOLVED FIXED
13 years ago
13 years ago

People

(Reporter: roc, Assigned: roc)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

While debugging columns I found a couple of really nasty subtle block reflow
bugs. I've finally tracked them down and fixed them. Once you know where to look
the bugs are obvious. I'll attach a patch.
Created attachment 154425 [details] [diff] [review]
fix

So there are two bugs. PullFrameFrom doesn't detect the last line correctly
because it looks at the current block instead of the line's container. The more
deadly bug, and the one that took me a really long time to track down, is that
someone thought "lines = flow->mLines", where lines is a nsLineBox&, would
rebind the reference, but it actually just copies the linked list pointers from
one block to another. Errrk.
Attachment #154425 - Flags: superreview?(dbaron)
Attachment #154425 - Flags: review?(dbaron)
Attachment #154425 - Flags: superreview?(dbaron)
Attachment #154425 - Flags: superreview+
Attachment #154425 - Flags: review?(dbaron)
Attachment #154425 - Flags: review+
Fix checked in. Thanks!
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.