253270 - standalone modules (xpcom, transformiix) should not pull toolkit or chrome

Status: RESOLVED INVALID

(Firefox Build System :: General, defect)

Description

[Axel Hecht]

Benjamin made seamonkey pull toolkit and chrome. The change makes standalone
modules like xpcom or transformiix standalone pull those, too. Which it shouldn't.

Comment 1

[Benjamin Smedberg]

bryner did it, not me. I agree XPCOM standalone shouldn't pull toolkit/, I am 
less sure about transformiix standalone. In particular, how does standalone 
transformiix get its localized strings without a chrome registry?

Comment 2

[Axel Hecht]

standalone transformiix only depends on xpcom/nspr, nothing else.
And this requirement is hardcoded in modules.mk, as the scripts generating those
deps catch the module dependencies, not the ones of standalone.

Comment 3

[Brian Ryner (not reading)]

Attachment: patch

Comment 4

[Axel Hecht]

Attachment: use CHECKOUT_ instead of CVSCO_

New patch, attachement 156051 didn't work.
The checkout lines use CHECKOUT_MOZTOOLKIT instead of CVSCO_MOZTOOLKIT, so I 
changed that.

Comment 5

[Mark Banner (:standard8)]

No longer SeaMonkey but Core, but I think this must be won't fix now?