253403 - compose window doesn't remember the size of "contacts" panel

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[nucleos]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; fr-FR; rv:1.7) Gecko/20040707 Firefox/0.8
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; fr-FR; rv:1.7) Gecko/20040707 Firefox/0.8

When you want to see the name _and_ the email address in the "contacts panel" to
be able to choose addresses so you know who they own, you often have to resize
the panel, but Thunderbird does not remember the size after being rebooted.

Reproducible: Always
Steps to Reproduce:
1. Open a new mail windows, and make the "contacts" sidebar appear by clicking
on "contacts"
2. Resize the sidebar however you want
3. Close Thunderbird
Actual Results:  
When you get in a new mail windows, the sidebar will be just as if you didn't
change it.

Expected Results:  
The sidebar should have remembered the size you wanted.

Comment 1

[Mike Cowperthwaite]

In fact, if you resize the contacts panel and then open a second compose window, 
that second window has the original size as well -- the compose window is cached 
(reused after closing for the next message); the setting appears to remain only 
for the lifetime of the window.

Comment 2

[u81239]

This is also a small issue for l10n, as in the Dutch translation the ‘add to To:’ and ‘add to Cc:’ buttons are wider (due to the translation of ‘add’ as ‘Toevoegen’, we can’t really think of anything shorter) and they overflow.

This isn’t terrible, but it would be nice if it would at least remember the width so that people who are bothered by it and resize the panel will not see it reset every time they re-open the window.


~Grauw

Comment 3

[Ton [:Tonnes]]

+1 for this bug, that should have been fixed long ago as I believe it is a regression compared to 1.0. I've also been using a workaround for too long now.. ;( As said, it would be good to know for the nl locale what will happen, as it's not only the Add/Cc buttons that aren't entirely viewable; the name/address column button may remain unnoticed as well.

If we can't expect a fix before 2.0, we (and possibily other locales) may need to change the strings (which is hard for nl indeed) or request for a startup width of at least 250. I guess fixing it won't be much harder though..

Comment 4

[Scott MacGregor]

should be an easy starter bug for someone looking to get involved. Not a blocker, would take a fix if one were contributed.

Comment 5

[Ton [:Tonnes]]

Laurens, how about changing the Dutch button strings involved to 'Naar Aan:' (/Cc:) (for now)? The current ones require a pretty wide column anyway..

Comment 6

[u81239]

I suppose that could do. What about ‘Als Aan:’ and ‘Als Cc:’? That seems a little better.

Comment 7

[Joey Minta]

Attachment: patch v1

It doesn't get much simpler than this... persist the width too.

Comment 8

[Phil Ringnalda (:philor)]

Comment on attachment 312611 [details] [diff] [review]
patch v1

The docs say persist is a space-separated list, so whether or not comma-separated works, it's asking to be broken.

Don't suppose you want to make the browser's style attribute localized, while it's sitting right down there in your context?

Comment 9

[Joey Minta]

Attachment: patch v2

This patch uses spaces.  I kind of want to wait for a localizer to file a specific bug on making the width locale specific, since I'm not sure whether it's still a problem, and thus worth going through the effort.

Comment 10

[Phil Ringnalda (:philor)]

Comment on attachment 312830 [details] [diff] [review]
patch v2

r=me - the minute I said "please patch the way someone tried to morph this bug into something different" I should have realized what I was saying :)

Comment 11

[Joey Minta]

Checking in mail/components/compose/content/messengercompose.xul;
/cvsroot/mozilla/mail/components/compose/content/messengercompose.xul,v  <--  messengercompose.xul
new revision: 1.116; previous revision: 1.115
done