253507 - Stored web page's images doesn't appears in offline mode

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Serzh]

User-Agent:       Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7) Gecko/20040707 Firefox/0.9.2
Build Identifier: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7) Gecko/20040707 Firefox/0.9.2

I saved web page using "save web page complete", then went to "work offline"
mode and tried t open this saved page. almost all images from this page didn't
appear.
When i searched stored file for url ot this images, they was local
<img src="biser_files/strek_01.jpg" alt="Стрекоза"
_base_href="http://win.mail.ru/cgi-bin/readmsg" border="1" height="345"
width="300"></center> 
but when i selected "copy image location" they give this url
http://win.mail.ru/cgi-bin/biser_files/strek_01.jpg

P.S. Then i tried to open this in IE in offline mode, awerything was ok

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Comment 1

[Serzh]

Attachment: Example of such saved page

Comment 2

[Martijn Wargers (dead)]

Attachment: Example of _base_href attribute

I don't know about such an attribute, but Mozilla seems to support the
_base_href attribute.
See this testcase link. In Mozilla it will take you to google. In Opera and IE
you're staying at the same page.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Serzh, can you point to a particular site that shows this problem so that a
potential fix could be tested?

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Proposed patch

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 154790 [details] [diff] [review]
Proposed patch

jst, what do you think?  The other possibility is to hack the HTML content sink
to ignore the _base_href attribute coming from the parser... but that seems
rather uncalled-for.

Comment 6

[Serzh]

(In reply to comment #3)
> Serzh, can you point to a particular site that shows this problem so that a
> potential fix could be tested?

This is public e-mail server www.mail.ru. I was seeng HTML letter in his
web-interface and then saved page with this letter. Saved page i attached packed
in gzip format. Why do you need web-site? Do you think that Firefox not properly
saved this page. IMHO, page saved ok, but Firefox cannot properly display it...
In IE this saved page is ok.

Comment 7

[Boris Zbarsky [:bzbarsky]]

> Do you think that Firefox not properly saved this page.

I don't just think it, I know it.  The proposed patch is a patch to the code
that saves pages to make it not screw up the page as it saves it.

Comment 8

[Johnny Stenback (:jst)]

Comment on attachment 154790 [details] [diff] [review]
Proposed patch

Seems reasonable. r+sr=jst

Comment 9

[Boris Zbarsky [:bzbarsky]]

Checked in.

Comment 10

[Boris Zbarsky [:bzbarsky]]

On trunk for 1.8a3, to be precise.