Closed
Bug 253521
Opened 20 years ago
Closed 19 years ago
use "Menu > Menuitem" everywhere
Categories
(Firefox Graveyard :: Help Documentation, defect)
Firefox Graveyard
Help Documentation
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox1.5
People
(Reporter: steffen.wilberg, Assigned: steffen.wilberg)
Details
Attachments
(1 file, 2 obsolete files)
4.52 KB,
patch
|
jwalden+fxhelp
:
review+
|
Details | Diff | Splinter Review |
In the Themes and Extensions sections in customization.xhtml, the reference to menuitems isn't like everywhere else.
Assignee | ||
Comment 1•20 years ago
|
||
This includes minor cleanup like removing double spaces.
Assignee | ||
Comment 2•20 years ago
|
||
Comment on attachment 154636 [details] [diff] [review] patch >-<p>Once in the Extensions dialog, select the extension that you wish to remove. >+<p>Once in the Extensions Manager, select the extension that you wish to remove. > Then, click the Uninstall button. You may need to close and then reopen >- &brandShortName; for all changes to take effect.</p> >+ &brandShortName; for changes to take effect.</p> I removed the "all" here, since there is no effect at all until you restart Firefox. For example, mouse gestures still work after uninstalling All-in-One Gestures.
Attachment #154636 -
Flags: review?(rlk)
Assignee | ||
Comment 3•20 years ago
|
||
Without the whitespace changes.
Comment 4•20 years ago
|
||
When I wrote the Language Style guide, I didn't mention sentence spacing. I considered it, but I didn't think it would matter much. Perhaps it matters a little more than I thought. Sentence spacing has to be the most nitpicky change I could have proposed. The end user never sees it. Both types of spacing are common. Maintaining a specific choice here requires a certain amount of effort. Is the return worth the effort? Out of habit I always used two, so my changes in the docs I've touched (which is probably most) are double-spaced between sentences. I've also seen some that were single-spaced (so my changes were double but the original stayed single). For this patch it doesn't matter because the work's already been done. In the future, tho, is it really a worthwhile goal to standardize sentence spacing? It's nothing the end user will ever see, and I get the feeling it'll just create more nitpicky work for any would-be patcher or reviewer.
Comment 5•20 years ago
|
||
As an FYI, R.J., there are some minor changes for bug 253538 that might be worth adding to this patch. The change would correct a grammatical error. I've outlined the necessary change in that bug, and I don't think it'll impact any l10n efforts.
Assignee | ||
Comment 6•20 years ago
|
||
R.J. said on IRC that we shouldn't use ">", because someone who needs Help might not understand that. So instead of this: Select <span class="menuPath">Tools > Options</span>. we should use this: Select <span class="menuPath">Options</span> from the <span class="menuPath">Tools</span> menu. A grep for ">" in browser/components/help/locales/en-US yields 26 hits (after I deleted my ~-files). But then someone said that "In Help code the standard form for citing menu items has been arbitrarily decided as Menu > [Submenu >] Menu Item (encased within a <span class="menuPath"> to keep consistency with the Mozilla Firefox site." http://www.mozilla.org/projects/help-viewer/documentation_coding-style.php#use_correct_element (I won't bother about spaces in the future, I completely forgot they're invisible in (x)html.)
Summary: use menuPath consistently: Menu > Menuitem → use "Menu > Menuitem" everywhere or nowhere
Assignee | ||
Updated•20 years ago
|
Attachment #154636 -
Attachment is obsolete: true
Attachment #154636 -
Flags: review?(rlk)
Assignee | ||
Updated•20 years ago
|
Attachment #154637 -
Attachment is obsolete: true
Comment 7•20 years ago
|
||
(In reply to comment #6) > "In Help code the standard form for citing menu items has been arbitrarily > decided as Menu > [Submenu >] Menu Item (encased within a <span > class="menuPath"> to keep consistency with the Mozilla Firefox site." That was me thinking that it would be good to keep it the same style as on http://texturizer.net/firefox/tips.html#beh_reuse (possibly after some minor discussion). If it needs to change I don't think anyone will care too much. I don't think it'll be particularly helpful for l10n, tho, because I remember part of the reason for the [Menu] > [Item] format was to help make them less confusing (by being consistent) and easier to localize.
Assignee | ||
Comment 8•20 years ago
|
||
R.J., we need a decision here: Use "Menu > Menuitem" everywhere or nowhere.
Comment 9•20 years ago
|
||
(In reply to comment #8) > R.J., we need a decision here: Use "Menu > Menuitem" everywhere or nowhere. nowhere
Comment 10•20 years ago
|
||
Steffen, We simply don't have time for this. It's too close to the release. A lot of the localizers have already started translating help and I wouldn't want to put them through this radical of a change. We can do this after 1.0.
No longer blocks: 253104
Target Milestone: --- → After Firefox 1.0
Comment 11•19 years ago
|
||
WONTFIX because what's used now is good enough, should be understandable, and is used on <http://www.mozilla.org/support/firefox/>.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → WONTFIX
Assignee | ||
Comment 12•19 years ago
|
||
See comment 0: "click on Tools from the menu bar and select the Themes menu item." That should be "select Tools > Themes". Reopening.
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
Summary: use "Menu > Menuitem" everywhere or nowhere → use "Menu > Menuitem" everywhere
Target Milestone: Future → Firefox1.1
Version: 1.0 Branch → Trunk
Assignee | ||
Comment 13•19 years ago
|
||
Fixes comment 12, and tweaks the wording.
Assignee | ||
Updated•19 years ago
|
Attachment #178458 -
Flags: review?(jwalden+fxhelp)
Updated•19 years ago
|
Attachment #178458 -
Flags: review?(jwalden+fxhelp) → review+
Assignee | ||
Comment 14•19 years ago
|
||
Checking in mozilla/browser/components/help/locale/en-US/customization.xhtml; /cvsroot/mozilla/browser/components/help/locale/en-US/customization.xhtml,v <-- customization.xhtml new revision: 1.17; previous revision: 1.16 done
Status: REOPENED → RESOLVED
Closed: 19 years ago → 19 years ago
Resolution: --- → FIXED
Updated•8 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•