253533 - Three entries for Thai fonts in fontEncoding.properties file have to be commented out for xft+gtk2 build

Status: RESOLVED FIXED

(Core Graveyard :: GFX: Gtk, defect)

Description

[Jungshik Shin]

fontEncoding.properties file has the following three lines:

encoding.norasi.ttf = x-thaittf-0.wide
encoding.garuda.ttf = x-thaittf-0.wide
encoding.dbthaitext.ttf = x-thaittf-0.wide

In gtk2 + xft build, we don't enable CTL so that 'x-thaittf-0' encoder is not
available. When one of three fonts are specified, it's not used because Mozilla
can't get the encoder for x-thaittf-0 (and thus its coverage is NOT known to
Gfx)  and as a result FindFont('a') fails. 

Therefore, we have to comment three lines above out

Comment 1

[Jungshik Shin]

Attachment: patch

comment out three entries

Comment 2

[Jungshik Shin]

Below is a part of the email I got from Thep:

-----------
The fonts used in the page are available at linux.thai.net CVS:
  cvs -d :pserver:[e-mail]:/home/cvs \
      co software/thaifonts-scalable
and are built with usual "configure; make; make install" process

With these fonts, I have provided some screenshots (of the page in the URL field
above) from my machine:
   http://linux.thai.net/~thep/tmp/fonttest/img/myshot1.png
   http://linux.thai.net/~thep/tmp/fonttest/img/myshot1.png

Note that not all fonts are actually selected as expected. Failed fonts
are Norasi, Garuda, and DBThaiText.

------------

Thep, as I mentioned in my email, you may want to apply my patch for bug 215219
for a better Thai rendering.  

Comment 3

[Theppitak Karoonboonyanan]

How is this going on? I have to say this bug has caused a major bug for Thai in
most non-local distros, such as Debian, where the only Thai fonts typically
installed are those prohibited by this bug.

Most Thai local distros have to apply this patch. That unfortunately blind most
Thai users from this problem in upstream source, however.

Comment 4

[Jungshik Shin]

Comment on attachment 154646 [details] [diff] [review]
patch

sorry for the delay. let's comment them out

Comment 5

[Jungshik Shin]

Comment on attachment 154646 [details] [diff] [review]
patch

asking for a to trunk. 
This only affects Thai rendering on Linux and has proven to work well (Thai
Linux community has applied this patch for a while every time a new release is
made)

Comment 6

[chris hofmann]

Comment on attachment 154646 [details] [diff] [review]
patch

a=chofmann

Comment 7

[Jungshik Shin]

landed on the trunk