Closed Bug 253698 Opened 18 years ago Closed 18 years ago

add "open in tabs" for live bookmarks

Categories

(Firefox :: Bookmarks & History, defect)

1.0 Branch
x86
All
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: Peter6, Assigned: quark29)

Details

(Keywords: fixed-aviary1.0)

Attachments

(1 file)

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040730
Firefox/0.9.1+

Go to "Bookmarks" menu
1.Rightclick on a "live bookmark folder" , "Open in Tabs" is missing.
2.In the folder it self the "Open in Tabs" at the bottom is missing
3.Middleclick on the "live bookmark folder" does not open the live bookmarks in
tabs.

A fix before 1.0 would be nice so the normal folders and live bookmark folders
hav the same behaviour.
Attached patch patchSplinter Review
As I told vlad, I don't know if this is a "should implement" or not.  I'll
leave that up to the devs.

This patch also adds bm_expandfolder to the Livemark command list, to make it
more consistent with Folders.
Flags: blocking-aviary1.0?
Comment on attachment 155528 [details] [diff] [review]
patch

Let's see if we can get a decision on this menu item.
Attachment #155528 - Flags: review?(vladimir)
Comment on attachment 155528 [details] [diff] [review]
patch

I'm not convinced of its utility from a RSS-reading perspective, but it should
definitely be there for publishing bookmarks and the like.

r=vladimir
Attachment #155528 - Flags: review?(vladimir) → review+
Attachment #155528 - Flags: approval-aviary?
Keywords: fixed-aviary1.0
checked in on branch
Assignee: vladimir → quark29
confirming fixed on branch

Open in tabs in the folder with bookmarks (at the bottom) itself is still missing.



forget comment 6 .
Somehow it did not show the first time (livemark was still loading)

Confirming all works
(In reply to comment #6)
> confirming fixed on branch
> 
> Open in tabs in the folder with bookmarks (at the bottom) itself is still missing.
> 
> 
> 
> 

Minor, as it only happens during the loading, but filed as bug 257285
Flags: blocking-aviary1.0?
confirmed fixed on Windows Firefox Branch 2004-09-10-08-0.9 and Mac Firefox
Branch 2004-09-10-07-0.9
--> FIXED
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
How about we leave this bug open until it's actually checked in on trunk?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a6) Gecko/20050108
Firefox/1.0+

WFM

->RESOLVED/FIXED
Status: REOPENED → RESOLVED
Closed: 18 years ago18 years ago
Resolution: --- → FIXED
sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change
QA Contact: mconnor → bookmarks
You need to log in before you can comment on or make changes to this bug.