there's this nice nsCRT::strtok_r function: http://lxr.mozilla.org/seamonkey/source/xpcom/ds/nsCRT.h#183 which can be used if you want a portable strtok_r implementation. bug 248768 shows the two (!!) places where mailnews has its own impl. at the very least, this function should only be impld _once_.
*** Bug 275425 has been marked as a duplicate of this bug. ***
add CC's that biesi initially added to a dupe'd bug
Created attachment 170041 [details] [diff] [review] Remove unused functions from AB code (checked in) The instance of the duplicated strtok function in the address book code mentioned in bug 248768 is not actually required, the two functions that use it are not used in the current mozilla code base. Therefore rather than trying to fix it and not be able to test the unused code, this patch simply removes the redundant functions. This patch doesn't touch the imap strtok code.
Attachment #170041 - Flags: superreview?(bienvenu)
Attachment #170041 - Flags: superreview?(bienvenu) → superreview+
Comment on attachment 170041 [details] [diff] [review] Remove unused functions from AB code (checked in) Neil checked this in 2005-01-03 04:45.
Attachment #170041 - Attachment description: Remove unused functions from AB code. → Remove unused functions from AB code (checked in)
Created attachment 170432 [details] [diff] [review] Replace strtok type functions in Imap code. This patch replaces the remaining Imapstrtok_r function with that from nsCRT::strtok. I have run with this for a few days on my dev suite and have not found any problems, I also completed the mailnews smoketests successfully. This appears to be the last duplicated instance of strtok in mailnews.
Assignee: sspitzer → mark
Status: NEW → ASSIGNED
Attachment #170432 - Flags: review?(bienvenu)
Attachment #170432 - Flags: superreview?(mscott)
Attachment #170432 - Flags: superreview?(mscott) → superreview+
Checking in mailnews/imap/src/nsIMAPGenericParser.cpp; /cvsroot/mozilla/mailnews/imap/src/nsIMAPGenericParser.cpp,v <-- nsIMAPGenericParser.cpp new revision: 1.44; previous revision: 1.43 done Checking in mailnews/imap/src/nsIMAPGenericParser.h; /cvsroot/mozilla/mailnews/imap/src/nsIMAPGenericParser.h,v <-- nsIMAPGenericParser.h new revision: 1.11; previous revision: 1.10 done Checking in mailnews/imap/src/nsImapServerResponseParser.cpp; /cvsroot/mozilla/mailnews/imap/src/nsImapServerResponseParser.cpp,v <-- nsImapServerResponseParser.cpp new revision: 1.118; previous revision: 1.117 done Checking in mailnews/imap/src/nsImapUrl.cpp; /cvsroot/mozilla/mailnews/imap/src/nsImapUrl.cpp,v <-- nsImapUrl.cpp new revision: 1.176; previous revision: 1.175 done
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
verified fixed via LXR
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.