254016 - Thunderbird nightlies default to local folders on IMAP account

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Jack Wilkinson]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040723 Firefox/0.9.1+
Build Identifier: 

In the recent nightlies through 080204, when I add an IMAP account to my profile
through the wizard, thunderbird sets the default "Copies and Folders" settings
(ie sent folder, drafts folder, templates folder) to the local folders.  In
0.7.2 and before, the default folders would be the sent/drafts/templates folders
on the IMAP server itself.

Reproducible: Always
Steps to Reproduce:
1. Start with clean profile
2. Create IMAP account
3. Go to account settings -> (account) -> Copies and Folders


Actual Results:  
The entries are all set as "place a copy in: Others - Sent on Local Folders", etc.

Expected Results:  
The entries should be "Place a copy in: Sent folder on: (account)"

I have tested this with imap servers running on both courier and iPlanet, and
have reverted back to 0.7.2 and have found that it works as expected with that
version.

Comment 1

[David :Bienvenu]

taking...

Comment 2

[David :Bienvenu]

fix coming up - I broke this when doing the global inbox. Need to break apart a
function into 2 functions.

Comment 3

[David :Bienvenu]

Attachment: proposed fix

break this method in two part; the first one needs to be called earlier; the
second one needs to be called with a valid account...

Comment 4

[Scott MacGregor]

Comment on attachment 155130 [details] [diff] [review]
proposed fix

you rock david

Comment 5

[Jack Wilkinson]

Just built with this patch--confirming that this fixes that issue... thanks guys!

Comment 6

[David :Bienvenu]

Attachment: fix getting new mail on startup with global inbox

While testing the above fix, I ran into the problem that getting new mail on 
initial thunderbird run when configuring a pop3 server to use the global inbox
wasn't working. I don't think the first fix caused this problem, but this patch
fixes it in any case.

Comment 7

[Jack Wilkinson]

related to bug 254290 perhaps?

Comment 8

[David :Bienvenu]

perhaps - I'll look into that - it might be the same fix.

Comment 9

[David :Bienvenu]

Attachment: fix special folders so they work for both imap and pop3 deferred case

ok, the previous fix broke the new pop3 account case, because it exposed an
existing bug for the pop3 case. This patch fixes both cases so they work...

Comment 10

[David :Bienvenu]

Comment on attachment 155316 [details] [diff] [review]
fix special folders so they work for both  imap and pop3 deferred case

fix this for the pop3 case now - make sure getCurrentServerIsDeferred only
returns true for pop3, and if we have a deferred account, use the local folders
account (in the wizard, pop3 accounts can *only* defer to the local folders
account)

Comment 11

[David :Bienvenu]

second fix checked into trunk and aviary branch.