Last Comment Bug 254132 - Can't add feeds when offline or Network down
: Can't add feeds when offline or Network down
Product: MailNews Core
Classification: Components
Component: Feed Reader (show other bugs)
: unspecified
: All All
-- minor (vote)
: Thunderbird 24.0
Assigned To: alta88
Depends on:
Blocks: 687428
  Show dependency treegraph
Reported: 2004-08-03 05:35 PDT by Nickolay_Ponomarev
Modified: 2013-06-25 05:19 PDT (History)
6 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

patch (4.30 KB, patch)
2013-06-16 12:41 PDT, alta88
mkmelin+mozilla: review+
Details | Diff | Splinter Review
for checkin (4.30 KB, patch)
2013-06-17 12:41 PDT, alta88
alta88: review+
Details | Diff | Splinter Review

Description User image Nickolay_Ponomarev 2004-08-03 05:35:57 PDT
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040730 Firefox/0.9.1+ (best browser EVAR1!!)
Build Identifier: Thunderbird 0.7+ (20040730)

When adding an RSS feed via Subscribe to feeds dialog, Thunderbird tries to
verify the feed, fails because the link is not available, and does not add the
feed to feeds list.

Reproducible: Always
Steps to Reproduce:
1. Create an RSS account
2. Click Subscribe to feeds
3. Click Add, try to add
Actual Results:  
"<...> could not be found" error message is shown, the feed is not added.

Expected Results:  
The feed is added, verification is delayed until connection is available (maybe
the feed should be verified when it's first checked for items?)

This doesn't work neither when TB thinks it is online but there's no connection,
nor when TB is in offline state. It is very inconvenient to copy my feeds from
another RSS reader, since I will have to be online just to add my feeds to the list.

This is with version 0.7+ (20040730), dialup connection on WinXP.
Comment 1 User image Scott MacGregor 2004-08-03 09:06:47 PDT
post 1.0...
Comment 2 User image Wayne Mery (:wsmwk, NI for questions) 2008-08-09 08:44:12 PDT
Dan, David,  ENH, bug or wonfix?  (bug was confirmed by dougweb)
Comment 3 User image Dan Mosedale (:dmose) 2008-08-11 11:34:37 PDT
ENH or bug, 6 of one, half a dozen of the other.  Worth doing in any case...
Comment 4 User image alta88 2013-06-16 12:41:42 PDT
Created attachment 763276 [details] [diff] [review]

1. if subscribing, and offline, the standard prompt will appear to download messages; if 'Go Online' is declined, the feed url is added anyway without validation, which can be done once online on next biff or manually.
2. also fixes Bug 687428.
Comment 5 User image Magnus Melin 2013-06-17 12:35:56 PDT
Comment on attachment 763276 [details] [diff] [review]

Review of attachment 763276 [details] [diff] [review]:

Sure, r=mkmelin

::: mailnews/extensions/newsblog/content/Feed.js
@@ +140,5 @@
> +    if ( {
> +      // If offline and don't want to go online, just add the feed subscription;
> +      // it can be verified later (the folder name will be the url if not adding
> +      // to an existing folder).  Only for subscribe actions; passive biff and

no double spacing please
Comment 6 User image alta88 2013-06-17 12:41:56 PDT
Created attachment 763739 [details] [diff] [review]
for checkin
Comment 7 User image Ryan VanderMeulen [:RyanVM] 2013-06-18 08:27:02 PDT

Note You need to log in before you can comment on or make changes to this bug.