Closed Bug 254132 Opened 15 years ago Closed 6 years ago

Can't add feeds when offline or Network down

Categories

(MailNews Core :: Feed Reader, defect, minor)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 24.0

People

(Reporter: asqueella, Assigned: alta88)

References

Details

Attachments

(1 file, 1 obsolete file)

4.30 KB, patch
alta88
: review+
Details | Diff | Splinter Review
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040730 Firefox/0.9.1+ (best browser EVAR1!!)
Build Identifier: Thunderbird 0.7+ (20040730)

When adding an RSS feed via Subscribe to feeds dialog, Thunderbird tries to
verify the feed, fails because the link is not available, and does not add the
feed to feeds list.

Reproducible: Always
Steps to Reproduce:
1. Create an RSS account
2. Click Subscribe to feeds
3. Click Add, try to add http://www.mozillazine.org/atom.xml
Actual Results:  
"<...> could not be found" error message is shown, the feed is not added.

Expected Results:  
The feed is added, verification is delayed until connection is available (maybe
the feed should be verified when it's first checked for items?)

This doesn't work neither when TB thinks it is online but there's no connection,
nor when TB is in offline state. It is very inconvenient to copy my feeds from
another RSS reader, since I will have to be online just to add my feeds to the list.

This is with version 0.7+ (20040730), dialup connection on WinXP.
post 1.0...
Target Milestone: --- → After Thunderbird 1.
Status: UNCONFIRMED → NEW
Ever confirmed: true
QA Contact: rss
Dan, David,  ENH, bug or wonfix?  (bug was confirmed by dougweb)
Assignee: mscott → nobody
Severity: normal → minor
Summary: Can't add feeds when offline → Can't add feeds when offline or Network down
ENH or bug, 6 of one, half a dozen of the other.  Worth doing in any case...
Severity: minor → normal
Component: RSS → Feed Reader
Product: Thunderbird → MailNews Core
Severity: normal → minor
Target Milestone: Future → ---
Attached patch patch (obsolete) — Splinter Review
1. if subscribing, and offline, the standard prompt will appear to download messages; if 'Go Online' is declined, the feed url is added anyway without validation, which can be done once online on next biff or manually.
2. also fixes Bug 687428.
Assignee: nobody → alta88
Attachment #763276 - Flags: review?(mkmelin+mozilla)
Blocks: 687428
Comment on attachment 763276 [details] [diff] [review]
patch

Review of attachment 763276 [details] [diff] [review]:
-----------------------------------------------------------------

Sure, r=mkmelin

::: mailnews/extensions/newsblog/content/Feed.js
@@ +140,5 @@
>  
> +    if (Services.io.offline) {
> +      // If offline and don't want to go online, just add the feed subscription;
> +      // it can be verified later (the folder name will be the url if not adding
> +      // to an existing folder).  Only for subscribe actions; passive biff and

no double spacing please
Attachment #763276 - Flags: review?(mkmelin+mozilla) → review+
Attached patch for checkinSplinter Review
Attachment #763276 - Attachment is obsolete: true
Attachment #763739 - Flags: review+
Keywords: checkin-needed
OS: Windows XP → All
Hardware: x86 → All
https://hg.mozilla.org/comm-central/rev/88b7851495c4
Status: NEW → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 24.0
You need to log in before you can comment on or make changes to this bug.