254132 - Can't add feeds when offline or Network down

Status: RESOLVED FIXED

(MailNews Core :: Feed Reader, defect)

Description

[Nickolay_Ponomarev]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040730 Firefox/0.9.1+ (best browser EVAR1!!)
Build Identifier: Thunderbird 0.7+ (20040730)

When adding an RSS feed via Subscribe to feeds dialog, Thunderbird tries to
verify the feed, fails because the link is not available, and does not add the
feed to feeds list.

Reproducible: Always
Steps to Reproduce:
1. Create an RSS account
2. Click Subscribe to feeds
3. Click Add, try to add http://www.mozillazine.org/atom.xml
Actual Results:  
"<...> could not be found" error message is shown, the feed is not added.

Expected Results:  
The feed is added, verification is delayed until connection is available (maybe
the feed should be verified when it's first checked for items?)

This doesn't work neither when TB thinks it is online but there's no connection,
nor when TB is in offline state. It is very inconvenient to copy my feeds from
another RSS reader, since I will have to be online just to add my feeds to the list.

This is with version 0.7+ (20040730), dialup connection on WinXP.

Comment 1

[Scott MacGregor]

post 1.0...

Comment 2

[Wayne Mery (:wsmwk)]

Dan, David,  ENH, bug or wonfix?  (bug was confirmed by dougweb)

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

ENH or bug, 6 of one, half a dozen of the other.  Worth doing in any case...

Comment 4

[alta88]

Attachment: patch

1. if subscribing, and offline, the standard prompt will appear to download messages; if 'Go Online' is declined, the feed url is added anyway without validation, which can be done once online on next biff or manually.
2. also fixes Bug 687428.

Comment 5

[Magnus Melin [:mkmelin]]

Comment on attachment 763276 [details] [diff] [review]
patch

Review of attachment 763276 [details] [diff] [review]:
-----------------------------------------------------------------

Sure, r=mkmelin

::: mailnews/extensions/newsblog/content/Feed.js
@@ +140,5 @@
>  
> +    if (Services.io.offline) {
> +      // If offline and don't want to go online, just add the feed subscription;
> +      // it can be verified later (the folder name will be the url if not adding
> +      // to an existing folder).  Only for subscribe actions; passive biff and

no double spacing please

Comment 6

[alta88]

Attachment: for checkin

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/88b7851495c4