254241 - Do not lookup gtk_style_get_prop_experimental in GTK2 build

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[Kyle Yuan]

http://lxr.mozilla.org/seamonkey/source/gfx/src/gtk/nsNativeThemeGTK.cpp#96
looks up the gtk_style_get_prop_experimental in *all* libraries. That consumes a
lot of time when mozilla startup (~70% of total startup time on Solaris).
Actually, this function does not exist in gtk2 library at all. We should exclude
this from gtk2 build until someone points out some equivalent function in gtk2. 

But anyway, calling PR_FindFunctionSymbolAndLibrary at startup seems a little
bit crazy to me.

Comment 1

[Kyle Yuan]

Attachment: proposed patch

with this patch, mozilla (solaris-sparc-gtk2) startup time can be reduced by
70%.

Comment 2

[Olivier Cahagne]

could we get this to bake on a Linux or Sun tinderbox to see check the startup
time improvement ? With bug 197301, startup time will then be very low. 

Comment 3

[Kyle Yuan]

the performance improvement on Linux is not obvious. maybe the problem is in
solaris' dlsym(). I don't know.

Comment 4

[Asa Dotzler [:asa]]

We're not going to hold the 1.8a4 release for this, but it's all ready to land
so if you want it in for a4, please get it landed quickly. 

Comment 5

[Kyle Yuan]

fixed.

Comment 6

[Asa Dotzler [:asa]]

If the patch author or reviewers believe this belongs on the aviary branch,
please request approval. 

Comment 7

[Kyle Yuan]

I think the patch is worth to be landed on aviary, because it's harmless and
very helpful to improve firefox's performance on Solaris.

Comment 8

[Asa Dotzler [:asa]]

Comment on attachment 155145 [details] [diff] [review]
proposed patch

a=asa for checkin to aviary branch.

Comment 9

[Kyle Yuan]

fixed in aviary branch.

Comment 10

[basic]

is there a bug about the equiv of gtk_stype_get_prop_experimental in gtk2?