254356 - incorrect line endings

Status: RESOLVED FIXED

(Calendar :: Internal Components, defect)

Description

[Richard van der Hoff]

User-Agent:       Mozilla/5.0 (X11; U; Linux i586; en-US; rv:1.7) Gecko/20040626 Firefox/0.9.1
Build Identifier: Sunbird nightly http://ftp.mozilla.org/pub/mozilla.org/calendar/sunbird/nightly/2004-07-01/MozillaSunbird-i686-pc-linux-gnu.tar.gz

lines in the iCalendar file are terminated with just a LF; this violates RFC
2445 which requires CRLF throughout, and prevents import of the file into some
other applications, in particular the current version of phpicalendar,
http://phpicalendar.net/forums/

Reproducible: Always
Steps to Reproduce:

Comment 1

[Mostafa Hosseini]

Fixed in CVS:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=mozilla%2Fother-licenses%2Flibical&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2004-09-07+09%3A12&maxdate=2004-09-07+09%3A12&cvsroot=%2Fcvsroot

Comment 2

[gekacheka]

Clicking the bonsai link in comment #1, near the patch there is 
  icalmemory_append_string(&buf, &buf_ptr, &buf_size, "BEGIN:VCALENDAR\n");
...
  icalmemory_append_string(&buf, &buf_ptr, &buf_size, "END:VCALENDAR\n");
Do these need to be changed to
  icalmemory_append_string(&buf, &buf_ptr, &buf_size, "BEGIN:VCALENDAR");
  icalmemory_append_string(&buf, &buf_ptr, &buf_size, newline);
...
  icalmemory_append_string(&buf, &buf_ptr, &buf_size, "END:VCALENDAR");
  icalmemory_append_string(&buf, &buf_ptr, &buf_size, newline);

Also this looks suspicious:

/* WIN32 automatically adds the \r, Anybody else need it?
#ifdef ICAL_UNIX_NEWLINE    
*/
    char newline[] = "\n";
/*
#else
    char newline[] = "\r\n";
#endif
*/

at:
http://lxr.mozilla.org/mozilla/source/other-licenses/libical/src/libical/icalcomponent.c#276



 

Comment 3

[Mostafa Hosseini]

Hmmm. Right. I'll post to the libical mailing list and see what they say.

Comment 4

[Mostafa Hosseini]

John: You made that change:
http://cvs.sourceforge.net/viewcvs.py/freeassociation/libical/src/libical/icalcomponent.c?r1=1.20&r2=1.21

It doesn't make sense to me how windows will add \r automatically. Maybe the
editor you were using to view the ical file did that? Can you confirm?

I'll post to libical anyway

Comment 5

[Mostafa Hosseini]

libical accepted the patch so I applied it too:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=mozilla%2Fother-licenses%2Flibical&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2004-09-10+06%3A38&maxdate=2004-09-10+06%3A38&cvsroot=%2Fcvsroot

Comment 6

[gekacheka]

Note: also requires patch in bug 259956 to prevent \r\r\n line ends.

Comment 7

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: Internal Components. Be afraid for your sanity!