254373 - [FIX]nsHTMLSelectElement::GetOptionIndex is slow

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Boris Zbarsky [:bzbarsky]]

This method is doing a lot of COM and QI stuff that's really unnecessary... it
should just be pushed down to where we don't have to worry about all that.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Like so

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 155234 [details] [diff] [review]
Like so

I considered just doing indexof and comparing its return to aStartIndex, taking
into account aForward, but then I decide maybe caller knows enough to be
passing "almost right" start indices.... (the only caller that passes a nonzero
start index and/or an aForward that's false is XBL form controls anyway).

Comment 3

[Peter Van der Beken [:peterv]]

Comment on attachment 155234 [details] [diff] [review]
Like so

>+nsHTMLOptionCollection::GetOptionIndex(nsIDOMHTMLOptionElement* aOption,

>+  PRInt32 high = mElements.Count();
>+  PRInt32 low = -1;
>+  PRInt32 step = aForward ? 1 : -1;
>+
>+  for (index = aStartIndex; index < high && index > low; index += step) {

You don't really need low, just use index > -1

Comment 4

[Boris Zbarsky [:bzbarsky]]

Fixed.