254557 - mail/app/Makefile.in DESTDIR typo lets 'make install DESTDIR=/tmp/somedir/' fail

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Alexander Sack]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040614 Firefox/0.8
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040614 Firefox/0.8

building the latest AVIARY version thunderbird fails when I use
make install DESTDIR=/tmp/somedir as a normal user.

I looked into the mozilla/mail/app/Makefile.in and found a typo for destdir.


Reproducible: Always
Steps to Reproduce:
1. make 
2. make install DESTDIR=/tmp/somedir - as a non-privileged user


Actual Results:  
fails with no write permissions to /usr/...


I attached the needed patch chunk for mail/app/Makefile.in here:

@@ -303,4 +303,4 @@
        $(INSTALL) $^ $(DIST)/bin/defaults/profile

 install:: $(srcdir)/profile/prefs.js
-       $(SYSINSTALL) $(IFLAGS1) $^ $(destdir)$(bindir)/defaults/profile
+       $(SYSINSTALL) $(IFLAGS1) $^ $(DESTDIR)$(bindir)/defaults/profile

Comment 1

[Jens Hatlak (:InvisibleSmiley)]

I do see this as well. As a quick fix for people trying to install Thunderbird
after building from source, one can just search for $(destdir) in
mozilla/mail/app/Makefile and replace it by $(DESTDIR).

BTW: I think bug 258177 is a duplicate of this one. Why did you file another one?

Comment 2

[Alexander Sack]

*** Bug 258177 has been marked as a duplicate of this bug. ***

Comment 3

[u29996]

Attachment: A simple fix

I *think* this is a correct patch. Please double check ...

Comment 4

[u29996]

Comment on attachment 164974 [details] [diff] [review]
A simple fix

Note that I am changing $(bindir) to $(mozappdir)

Comment 5

[Jens Hatlak (:InvisibleSmiley)]

This applies to Firefox as well, and Firefox 1.0 shipped without a patch for it.
Very sad... Should another bug be opened for Firefox? And why is no-one with
sufficient rights working on this one? It can be reproduced 100% and we have a fix.

Just as I said in comment #1, patching the Makefile works. Just replace mail/ by
browser/.

Comment 6

[Jens Hatlak (:InvisibleSmiley)]

The correspondig bug for Firefox has been fixed (bug 255958; bug 263524 seems to
be the same but it's still not closed). What about this one?

Comment 7

[Marcia Knous [:marcia]]

won't make the 1.0 train, minusing. sounds like there are a few workarounds.

Comment 8

[Alexander Sack]

can someone please confirm this bug? or maybe just review the attached patch?

Comment 9

[Scott MacGregor]

Comment on attachment 164974 [details] [diff] [review]
A simple fix

I'll let Benjamin decide what the right thing is here. The patch seems fine to
me but I know little about these things.

Did you want to attach a patch for Firefox too?

Comment 10

[Alexander Sack]

> Did you want to attach a patch for Firefox too?

Scott, 

I don't think this is necessary anymore. I see this fixed in ffox 1.0.3. Unless
has not been merged to the trunk, it should be fine.

Comment 11

[Jens Hatlak (:InvisibleSmiley)]

Just one question: Has anything been checked in? I mean, comments 9 an 10 were
about *Firefox*. I already stated in comment 6, about *four months ago*, that
the *corresponding* Firefox bug had been fixed. *This* bug is about Thunderbird,
concerning *different* files, as far as I know. So how can *this bug* be fixed?

Comment 12

[Alexander Sack]

Jens,

everthing is fine ... Scott checked in this patch for thunderbird.

Comment 13

[Adam Guthrie]

*** Bug 305917 has been marked as a duplicate of this bug. ***