The default bug view has changed. See this FAQ.

Status

SeaMonkey
MailNews: Message Display
RESOLVED FIXED
13 years ago
12 years ago

People

(Reporter: M.J.G., Unassigned)

Tracking

({fixed1.8, regression})

Trunk
x86
All
fixed1.8, regression

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

13 years ago
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040805 Firefox/0.9.3
Build Identifier: Mozilla Thunderbird 0.7.2 (X11/20040716)

Mailnews/Thunderbird should display buddy icons as described in
http://www.mozilla.org/mailnews/arch/buddyicons.html, i.e. they should show uop
in message view (headers expanded) and card view (addressbook).
Alas, nothing is shown.

Reproducible: Always
Steps to Reproduce:
1. Set up buddy icons (icons and addressbook card) as per
http://www.mozilla.org/mailnews/arch/buddyicons.html
2. Call up message view (expanded) or address card.
3. 

Actual Results:  
No buddy icons are visible. No visual difference to the case without buddy icons.

Expected Results:  
Display buddy icons.

Same in cvs.
(Reporter)

Comment 1

13 years ago
Digging into abCardViewOverlay.js, I noticed that a call to XPCOM's directory
service is wrong ("@mozilla.org/directory_service;1" instead of
"@mozilla.org/file/directory_service;1"). The attached patch is a one liner, it
works for me in the addressbook. The patch is against the version from TBird's
0.7.2 source tar ball, but I checked that the current version is still missing
the "/file" part.

The same one-liner as for abCardView works for msgHdrView and implements the
correct behaviour for the message header view.
(Reporter)

Comment 2

13 years ago
Created attachment 155353 [details] [diff] [review]
patch to abCardViewOverlay.js
(Checked in)

patch to abCardViewOverlay.js from content/messenger/addressbook in mail.jar
(Reporter)

Comment 3

13 years ago
Created attachment 155354 [details] [diff] [review]
patch to msgHdrViewOverlay.js (Checked in)

patch to msgHdrViewOverlay.js from content/messenger in mail.jar
(Reporter)

Comment 4

13 years ago
This affects components "Mail Window Fron End" and "Addressbook". How do I
specify two components?
(Reporter)

Updated

13 years ago
Attachment #155353 - Flags: review?(mscott)
(Reporter)

Updated

13 years ago
Attachment #155354 - Flags: review?(mscott)
Product: Browser → Seamonkey

Updated

12 years ago
Assignee: sspitzer → mail

Updated

12 years ago
Status: UNCONFIRMED → NEW
Ever confirmed: true

Comment 5

12 years ago
Comment on attachment 155353 [details] [diff] [review]
patch to abCardViewOverlay.js
(Checked in)

Changing to someone who will r/sr on mailnews
Attachment #155353 - Flags: superreview?(bienvenu)
Attachment #155353 - Flags: review?(mscott)
Attachment #155353 - Flags: review?(bienvenu)

Comment 6

12 years ago
Comment on attachment 155354 [details] [diff] [review]
patch to msgHdrViewOverlay.js (Checked in)

Changing to someone who will r/sr on mailnews
Attachment #155354 - Flags: superreview?(bienvenu)
Attachment #155354 - Flags: review?(mscott)
Attachment #155354 - Flags: review?(bienvenu)

Updated

12 years ago
Attachment #155353 - Flags: superreview?(bienvenu)
Attachment #155353 - Flags: superreview+
Attachment #155353 - Flags: review?(bienvenu)
Attachment #155353 - Flags: review+

Updated

12 years ago
Attachment #155354 - Flags: superreview?(bienvenu)
Attachment #155354 - Flags: superreview+
Attachment #155354 - Flags: review?(bienvenu)
Attachment #155354 - Flags: review+

Updated

12 years ago
Attachment #155353 - Attachment description: patch to abCardViewOverlay.js → patch to abCardViewOverlay.js (Checked in)

Updated

12 years ago
Attachment #155354 - Attachment description: patch to msgHdrViewOverlay.js → patch to msgHdrViewOverlay.js (Checked in)

Comment 7

12 years ago
Checking in (trunk)
base/resources/content/msgHdrViewOverlay.js; new revision: 1.142; previous
revision: 1.141
addrbook/resources/content/abCardViewOverlay.js; new revision: 1.37; previous
revision: 1.36
done
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED

Comment 8

12 years ago
Comment on attachment 155353 [details] [diff] [review]
patch to abCardViewOverlay.js
(Checked in)

requesting a= for simple, low risk, regression fix
Attachment #155353 - Flags: approval1.8b5?

Comment 9

12 years ago
Comment on attachment 155354 [details] [diff] [review]
patch to msgHdrViewOverlay.js (Checked in)

requesting a= for simple, low risk, regression fix
Attachment #155354 - Flags: approval1.8b5?
Keywords: regression

Updated

12 years ago
Attachment #155353 - Flags: approval1.8b5? → approval1.8b5+

Comment 10

12 years ago
Comment on attachment 155354 [details] [diff] [review]
patch to msgHdrViewOverlay.js (Checked in)

Approved for 1.8b5 per bug meeting
Attachment #155354 - Flags: approval1.8b5? → approval1.8b5+

Comment 11

12 years ago
Checking in (branch)
addrbook/resources/content/abCardViewOverlay.js; new revision: 1.36.26.1;
previous revision: 1.36
base/resources/content/msgHdrViewOverlay.js; new revision: 1.141.2.1; previous
revision: 1.141
done
Keywords: fixed1.8
You need to log in before you can comment on or make changes to this bug.