a lot of places assume cacheToken can be qi'd to nsICacheEntryDescriptor

RESOLVED FIXED in mozilla1.8alpha3

Status

SeaMonkey
General
RESOLVED FIXED
14 years ago
13 years ago

People

(Reporter: Biesinger, Assigned: Biesinger)

Tracking

Trunk
mozilla1.8alpha3
x86
Linux

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

the API only guarantees QI-ability to nsICacheEntryInfo.
Created attachment 155360 [details] [diff] [review]
patch

hm... this patch does slightly more than cacheentryinfo. but, while I'm here,
I'd like to get that in too, if you don't mind.
Comment on attachment 155360 [details] [diff] [review]
patch

unfortunately I could not change all callers, since some need
nsICacheEntryDescriptor :(
Attachment #155360 - Flags: superreview?(darin)
Attachment #155360 - Flags: review?(bzbarsky)
Comment on attachment 155360 [details] [diff] [review]
patch

r=bzbarsky for all of it, but could you split up the docshell change into two
checkins?  Otherwise the cvs log/blame will be _very_ confusing...
Attachment #155360 - Flags: review?(bzbarsky) → review+
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.8alpha3

Comment 4

14 years ago
Comment on attachment 155360 [details] [diff] [review]
patch

sr=darin
Attachment #155360 - Flags: superreview?(darin) → superreview+
refcounted views part:
Checking in docshell/base/nsDocShell.cpp;
/cvsroot/mozilla/docshell/base/nsDocShell.cpp,v  <--  nsDocShell.cpp
new revision: 1.614; previous revision: 1.613
done

cache token part:
Checking in docshell/base/nsDocShell.cpp;
/cvsroot/mozilla/docshell/base/nsDocShell.cpp,v  <--  nsDocShell.cpp
new revision: 1.613; previous revision: 1.612
done
Checking in modules/libpr0n/src/imgRequest.cpp;
/cvsroot/mozilla/modules/libpr0n/src/imgRequest.cpp,v  <--  imgRequest.cpp
new revision: 1.80; previous revision: 1.79
done
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.