Closed
Bug 254696
Opened 20 years ago
Closed 20 years ago
Download Manager should open file/display properties when you hit enter
Categories
(SeaMonkey :: Download & File Handling, enhancement)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla1.8beta1
People
(Reporter: csthomas, Assigned: csthomas)
Details
Attachments
(1 file, 6 obsolete files)
2.84 KB,
patch
|
Details | Diff | Splinter Review |
Pressing enter should have the same effect as double-clicking a file.
Assignee | ||
Comment 1•20 years ago
|
||
Assignee | ||
Updated•20 years ago
|
Attachment #155428 -
Flags: review?(neil.parkwaycc.co.uk)
Assignee | ||
Comment 2•20 years ago
|
||
Comment on attachment 155428 [details] [diff] [review] Patch Errr, that's not what I meant to attach.
Attachment #155428 -
Attachment is obsolete: true
Attachment #155428 -
Flags: review?(neil.parkwaycc.co.uk)
Assignee | ||
Comment 3•20 years ago
|
||
Assignee | ||
Comment 4•20 years ago
|
||
<bz> That tab you added to the XUL should go, in any case.
Attachment #155429 -
Attachment is obsolete: true
Comment 5•20 years ago
|
||
The patch looks good although the code duplication isn't nice :-/
Assignee | ||
Comment 6•20 years ago
|
||
Alternate patch (no code duplication).
Assignee | ||
Updated•20 years ago
|
Attachment #155430 -
Flags: review?(neil.parkwaycc.co.uk)
Assignee | ||
Updated•20 years ago
|
Attachment #155442 -
Flags: review?(neil.parkwaycc.co.uk)
Assignee | ||
Comment 7•20 years ago
|
||
Add space around ==, even up line lengths.
Assignee | ||
Comment 8•20 years ago
|
||
[08/07/2004][18:10] <NeilAlmostZZZ> CTho: r=me on that latest patch
Attachment #155430 -
Attachment is obsolete: true
Attachment #155442 -
Attachment is obsolete: true
Attachment #155444 -
Attachment is obsolete: true
Assignee | ||
Updated•20 years ago
|
Attachment #155442 -
Flags: review?(neil.parkwaycc.co.uk)
Assignee | ||
Updated•20 years ago
|
Attachment #155430 -
Flags: review?(neil.parkwaycc.co.uk)
Assignee | ||
Updated•20 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Updated•20 years ago
|
Flags: blocking1.8a3?
Target Milestone: --- → mozilla1.8alpha3
Comment 9•20 years ago
|
||
Comment on attachment 155445 [details] [diff] [review] Final version I'd just like to point out that in my local time it was actually 2004-08-08 00:10 :-P
Attachment #155445 -
Flags: review+
Assignee | ||
Updated•20 years ago
|
Attachment #155445 -
Flags: superreview?(jag)
Comment 10•20 years ago
|
||
Comment on attachment 155445 [details] [diff] [review] Final version sr=jag Was just thinking though, we probably shouldn't hardcode 13, but instead use KeyEvent.DOM_VK_RETURN I wonder where that |KeyEvent| comes from. Quite a few places seem to be using it, but I don't see where it is defined. If that doesn't work, Components.interfaces.nsIDOMKeyEvent.DOM_VK_RETURN will.
Attachment #155445 -
Flags: superreview?(jag) → superreview+
Assignee | ||
Comment 11•20 years ago
|
||
Neil, if this is ok, could you check it in?
Attachment #155445 -
Attachment is obsolete: true
Comment 12•20 years ago
|
||
Yes, it is ok, I was just too tired to check before the freeze :-( We really need to sort out this VK_RETURN / VK_ENTER confusion some day; the keyCode of 13 which we call VK_RETURN is called Enter by most documentation, while our VK_ENTER is not actually generated by any of our platforms...
Assignee | ||
Updated•20 years ago
|
Flags: blocking1.8a3?
Target Milestone: mozilla1.8alpha3 → mozilla1.8beta
Assignee | ||
Comment 13•20 years ago
|
||
Timeless checked the patch in.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Verified FIXED using build 2004-08-23-08 on Windows XP, Seamonkey trunk. I checked both Enter keys (alphabet keypad and the numeric keypad), but I'm trusting this works on mac, too (if that was the intention). If that's broken, file a bug on that, specifically.
Status: RESOLVED → VERIFIED
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•