254978 - npapi.h needs symbolic constant to indicate minimum version for npruntime support

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Jonathan Brecher]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8a3) Gecko/20040808
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8a3) Gecko/20040808

npapi.h was recently modified to support the new npruntime api (Bug 250666, Bug
253570, tracking Bug 251151).  It needs a new symbolic constant to indicate the
minimum version with this support.  Something along the lines of this should do
it, maybe:

/*
 * Version feature information
 */
#define NPVERS_HAS_STREAMOUTPUT      8
#define NPVERS_HAS_NOTIFICATION      9
#define NPVERS_HAS_LIVECONNECT       9
#define NPVERS_WIN16_HAS_LIVECONNECT 9
#define NPVERS_68K_HAS_LIVECONNECT   11
#define NPVERS_HAS_WINDOWLESS        11
#define NPVERS_HAS_XPCONNECT_SCRIPTING 13
#define NPVERS_HAS_NPRUNTIME         14         <-- New line added




Reproducible: Always
Steps to Reproduce:

Comment 1

[Gervase Markham [:gerv]]

This is an automated message, with ID "auto-resolve01".

This bug has had no comments for a long time. Statistically, we have found that
bug reports that have not been confirmed by a second user after three months are
highly unlikely to be the source of a fix to the code.

While your input is very important to us, our resources are limited and so we
are asking for your help in focussing our efforts. If you can still reproduce
this problem in the latest version of the product (see below for how to obtain a
copy) or, for feature requests, if it's not present in the latest version and
you still believe we should implement it, please visit the URL of this bug
(given at the top of this mail) and add a comment to that effect, giving more
reproduction information if you have it.

If it is not a problem any longer, you need take no action. If this bug is not
changed in any way in the next two weeks, it will be automatically resolved.
Thank you for your help in this matter.

The latest beta releases can be obtained from:
Firefox:     http://www.mozilla.org/projects/firefox/
Thunderbird: http://www.mozilla.org/products/thunderbird/releases/1.5beta1.html
Seamonkey:   http://www.mozilla.org/projects/seamonkey/

Comment 2

[Jonathan Brecher]

I agree that this bug has had no comments for a long time. It is unfortunate that the developers of the 
Mizilla projects are unable even to review newly entered bugs.

Unless the Plugin API is frozen for all time such that there will never ever be any additional versioning 
to the npapi.h file, this bug should NOT be closed!

Comment 3

[Ben Karel [eschew]]

A line such as the one proposed was added as part of a fix for bug 299054.

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=/mozilla/modules/plugin/base/public&command=DIFF_FRAMESET&file=npapi.h&rev2=3.44&rev1=3.43

Marking FIXED.