254993 - Make left tab panel flexible so calendar-list height is adjustable with left splitter.

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[gekacheka]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.2) Gecko/20040803
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.2) Gecko/20040803, 20040809-cal

Currently the calendars list/minimonth tab panel has fixed height, so the
splitter in the left column (between the tasks pane and the calendars list) is
not very useful.  This tab panel should be resizable, so more space can be given
to view the calendars list if there are many calendars.

Reproducible: Always
Steps to Reproduce:
1. Attempt to move the splitter in the left column up or down.

Actual Results:  
If you move the splitter up, the tab panel collapses so the calendars and 
minimonth are not visible (all space given to task list).
If you move splitter down, the calendars list does not gain any height.

Expected Results:  
If you move the splitter up, tab panel gets shorter until it reaches the minimum
height of the contents (minimonth), then collapses.
If you move the splitter down, tab panel gets taller and more lines of the
calendar list can be seen at once.

Comment 1

[gekacheka]

Attachment: calendar.xul patch: add flex to tabpanels, adjust flex, add maxheight to minimonth, add spacers

0. Adjust indentation of tab elements to show nesting
1. add flex to <tabpanels> element.
2. give 'left-hand-below-splitter' flex of 99999 so pane above splitter does
not change size when window resizes.
3. give minimonth a maxheight and add spacers above and below so it doesn't get
too stretched out when its pane is tall.  Give minimonth flex 8 and spacers
flex 1 so minimonth will take most of the height adjustment until it reaches
its max height.

Tested on Mozilla 1.7.2, Mozilla 1.8a2, Firefox 0.9.3.

Comment 2

[Mostafa Hosseini]

Checked in, along with indentation fixes.
Also updated calendar.xul in calendar/sunbird/base/content

Comment 3

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: Sunbird Only. Be afraid for your sanity!