255011 - Recent padding reduction is too much

Status: VERIFIED INVALID

(Firefox :: Toolbars and Customization, defect)

Description

[Peter Hewitt]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040809 Firefox/0.9.1+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040809 Firefox/0.9.1+

From yesterday the winstripe buttons had their padding reduced to make them less
spaced out however the amount by which the padding has been reduced means that
in small icons mode the icons are tiny and quite hard to hit (see attached).

Could the padding be increased again slightly please?

Reproducible: Always
Steps to Reproduce:
1. Get new nightly
2. look at icons in small icons mode
Actual Results:  
Icons now too small and hard to hit

Expected Results:  
Icons should have a bit more padding on them

Comment 1

[Peter Hewitt]

Attachment: Screenshot of the icons being small

Comment 2

[Peter Hewitt]

Aftering fiddling with userchrome I think 3px padding on them would be
sufficent, it's not as large as the old buttons (which were 5px I believe)
however it's easier to fix than the current set of buttons.

toolbar[iconsize="small"] .toolbarbutton-1 .toolbarbutton-icon {
  margin-right: 0px;
  padding: 3px;
}

Comment 3

[Jesse Ruderman]

I agree.  Tall rectangular buttons look weird too.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

This is probably a good idea for usability and even for aesthetics, but people who want their toolbars as minimal as possible might not like it. I think it's still a good idea.

Comment 5

[Peter Hewitt]

this bug is well out of date an irrelevent. if its ok i'll mark it as invalid as it doesn't count anymore. might help reduce useless open bug count