Signature files should be copied from Mozilla profile directories

RESOLVED FIXED in Thunderbird1.0

Status

Thunderbird
Migration
RESOLVED FIXED
14 years ago
14 years ago

People

(Reporter: Max Spicer, Assigned: Scott MacGregor)

Tracking

unspecified
Thunderbird1.0
x86
Windows XP

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

14 years ago
If a signature file is stored in a user's Mozilla profile directory, it should
be copied to the new Thunderbird profile directory during the migration. 
Currently thunderbird links to the signature within the Mozilla profile
directory (but see   bug 255034).  This is a problem, as someone migrating from
Mozilla may well then delete their Mozilla profile, thus breaking the signature.
 We should probably assume that people are going to stick with Thunderbird after
the migration.  Copying the signature file could lead to problems with people
trying to share the file between Mozilla and Thunderbird, but I think they'd be
in the minority.

Comment 1

14 years ago
I would agree that moving a signature file stored previously in a profile
directory is probably the best course of action. However all other signatures
(e.g. those outside of the profile directory) should remain untouched. If we
respect this rule we make it easy for users to decide if they want
mozilla/thunderbird to manage their signature for them or do it themselves. 
(Assignee)

Comment 2

14 years ago
will consider for .9
Status: NEW → ASSIGNED
Target Milestone: --- → Thunderbird0.9
(Assignee)

Comment 3

14 years ago
missed the gravy train. Not a .9 stopper
Target Milestone: Thunderbird0.9 → Thunderbird1.0
(Assignee)

Comment 4

14 years ago
Created attachment 167293 [details] [diff] [review]
the fix
(Assignee)

Updated

14 years ago
Attachment #167293 - Flags: superreview?(bienvenu)

Comment 5

14 years ago
Comment on attachment 167293 [details] [diff] [review]
the fix

+      mTargetProfile->Clone(getter_AddRefs(targetSigFile));

should we check for failure here?
Attachment #167293 - Flags: superreview?(bienvenu) → superreview+
(Assignee)

Comment 6

14 years ago
fixed branch and trunk.

I added a NS_ENSURE_SUCCESS check after the function call to ::Clone.
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.