255043 - Signature files should be copied from Mozilla profile directories

Status: RESOLVED FIXED

(Thunderbird :: Migration, defect)

Description

[Max Spicer]

If a signature file is stored in a user's Mozilla profile directory, it should
be copied to the new Thunderbird profile directory during the migration. 
Currently thunderbird links to the signature within the Mozilla profile
directory (but see   bug 255034).  This is a problem, as someone migrating from
Mozilla may well then delete their Mozilla profile, thus breaking the signature.
 We should probably assume that people are going to stick with Thunderbird after
the migration.  Copying the signature file could lead to problems with people
trying to share the file between Mozilla and Thunderbird, but I think they'd be
in the minority.

Comment 1

[Michael Favia]

I would agree that moving a signature file stored previously in a profile
directory is probably the best course of action. However all other signatures
(e.g. those outside of the profile directory) should remain untouched. If we
respect this rule we make it easy for users to decide if they want
mozilla/thunderbird to manage their signature for them or do it themselves. 

Comment 2

[Scott MacGregor]

will consider for .9

Comment 3

[Scott MacGregor]

missed the gravy train. Not a .9 stopper

Comment 4

[Scott MacGregor]

Attachment: the fix

Comment 5

[David :Bienvenu]

Comment on attachment 167293 [details] [diff] [review]
the fix

+      mTargetProfile->Clone(getter_AddRefs(targetSigFile));

should we check for failure here?

Comment 6

[Scott MacGregor]

fixed branch and trunk.

I added a NS_ENSURE_SUCCESS check after the function call to ::Clone.