255095 - npupp.h needs upps for npruntime "invoke" function

Status: RESOLVED WONTFIX

(Core Graveyard :: Embedding: ActiveX Wrapper, defect)

Description

[Jonathan Brecher]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8a3) Gecko/20040808
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8a3) Gecko/20040808

npupp.h was recently modified to add UPPs for all of the new fuctions defined in
npruntime.h *except* the "invoke" function.  

UPPs should be added for NewNPN_InvokeProc and CallNPN_InvokeProc to match the
others that are already there.

Reproducible: Always
Steps to Reproduce:

Comment 1

[Johnny Stenback (:jst)]

There is no NPN_Invoke method in the new API, there's only a NPClass hook called
invoke. The NPN function that calls the NPClass invoke hook is called NPN_Call,
and that's in npupp.h already.

Comment 2

[Johnny Stenback (:jst)]

Oh, and yeah, I know this is inconsitent, for no other reasons than that noone
caught this inconsistency in time :-(

Comment 3

[Jonathan Brecher]

It's not too late to clarify this for everyone else.  How about adding

// There is no NPN_Invoke method in the new API, there's only 
// a NPClass hook called invoke. The NPN function that calls 
// the NPClass invoke hook is called NPN_Call
#define NewNPN_InvokeProc NewNPN_CallProc
#define CallNPN_InvokeProc CallNPN_CallProc

to the headers?  Doesn't seem like there's any harm in that approach, and
clarity is a Good Thing.  (Of course, I'm pretty sure that the entire npupp.h
file is obsolete now, but we've had it in our project for ages, and since you
still have it in yours I didn't come to that conclusion until after I had found
this issue.)

Comment 4

[Gervase Markham [:gerv]]

This is an automated message, with ID "auto-resolve01".

This bug has had no comments for a long time. Statistically, we have found that
bug reports that have not been confirmed by a second user after three months are
highly unlikely to be the source of a fix to the code.

While your input is very important to us, our resources are limited and so we
are asking for your help in focussing our efforts. If you can still reproduce
this problem in the latest version of the product (see below for how to obtain a
copy) or, for feature requests, if it's not present in the latest version and
you still believe we should implement it, please visit the URL of this bug
(given at the top of this mail) and add a comment to that effect, giving more
reproduction information if you have it.

If it is not a problem any longer, you need take no action. If this bug is not
changed in any way in the next two weeks, it will be automatically resolved.
Thank you for your help in this matter.

The latest beta releases can be obtained from:
Firefox:     http://www.mozilla.org/projects/firefox/
Thunderbird: http://www.mozilla.org/products/thunderbird/releases/1.5beta1.html
Seamonkey:   http://www.mozilla.org/projects/seamonkey/

Comment 5

[Jonathan Brecher]

The inconsistency was acknowledged above, and a fix proposed. How about taking the moment to fix 
this, rather than taking that much time (and longer) arguing that you don't want to?

Comment 6

[aravindm]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2.2)
Gecko/20100316 Firefox/3.6.2
Please try if you can still reproduce with the latest nightly build ftp://ftp.mozilla.org/pub/firefox/nightly/latest-trunk/

Comment 7

[Benjamin Smedberg]

ActiveX code is being removed momentarily.