255142 - The radio groups "Cookie Acceptance Policy" and "Cookie Lifetime Policy" are not lockable

Status: RESOLVED WORKSFORME

(Core :: Networking: Cookies, defect)

Description

[Boying Lu]

Lock the preferences "network.cookie.cookieBehavior" and
"network.cookie.lifetimePolicy" in autoconfig.jsc. 
But the corresponding radio groups in Privacy & Security-->Cookies  are not
disabled.

Comment 1

[Boying Lu]

Attachment: patch v0

Comment 2

[Boying Lu]

Comment on attachment 155780 [details] [diff] [review]
patch v0

can you give r? Thanks

Comment 3

[[e-mail]]

this belongs in the cookie component.

mconnor, can you please take a look at this few-liner?

Comment 4

[Mike Connor [:mconnor]]

Boying, I tested both of these and they work fine on a recent trunk build.  We
should only need to do manual locking if we're also doing manual
enabling/disabling of the element.  The prefwindow API takes care of this itself.

Comment 5

[Boying Lu]

Mike, 
  Would you please tell me the detailed steps you test. Thanks

Comment 6

[Mike Connor [:mconnor]]

I created a mozilla.cfg with the appropriate lockPref entry, added the
appropriate pref as follows

// silly comment on the first line
lockPref("network.cookie.cookieBehavior", 2);

I then added the following pref to all.js:
pref("general.config.filename", "mozilla.cfg");
also, so as to not require constantly converting the file, I turned off
byteshifting by setting general.config.obscure_value to 0.

It works fine, based on that.   Really, the mechanics of how to lock the pref
are irrelevant, as long as about:config shows the pref as locked.  From there,
the prefwindow API will lock the UI unless we futz with disabling/enabling it
ourself.

The bits at
http://lxr.mozilla.org/mozilla/source/xpfe/components/prefwindow/resources/content/nsPrefWindow.js#388
are what I'm talking about.