255232 - Print Preview opens in tab instead of preview window, crash if Close Tab [@ nsSplittableFrame::Destroy ][@ 0x00000000 - nsIView::Destroy ]

Status: RESOLVED WORKSFORME

(Core :: Print Preview, defect)

Description

[Nicholas Shewmaker]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.2) Gecko/20040803
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.2) Gecko/20040803

On certain sites, if I choose Print Preview (from the Print icon or the File
menu), the preview is opened in the tab (I have a screen capture if needed.)
instead of the Preview window. There is no way to go back or cancel the preview,
and closing the tab with either Tab > Close Tab or the X button crashes the browser.

I reproduced this with Slashdot after having it happen at MS TechNet. I have the
Tabbrowser extension installed, among others.

Reproducible: Sometimes
Steps to Reproduce:
1. Browse to a site.
2. Open Print Preview.
3. If the preview is in a tab, attempt to Close Tab (X).

Actual Results:  
Mozilla crashes.

Expected Results:  
The Preview should be in a different window, with a Close button.

Comment 1

[Nicholas Shewmaker]

It doesn't seem to be dependent upon the number of tabs open. Certain sites
(like Slashdot) always seem to do it, whereas others seem fine.

Comment 2

[Adam Hauner]

Nicholas: Could you provide TalkBack incident ID?

Comment 3

[Nicholas Shewmaker]

535569, 535594, 537934

Comment 4

[Adam Hauner]

TB535569:
0x04fa2669
nsSplittableFrame::Destroy 
[d:/BUILDS/tinderbox/Mozilla1.7/WINNT_5.0_Clobber/mozilla/layout/html/base/src/nsSplittableFrame.cpp,
line 72]
nsContainerFrame::Destroy 
[d:/BUILDS/tinderbox/Mozilla1.7/WINNT_5.0_Clobber/mozilla/layout/html/base/src/nsContainerFrame.cpp,
line 171]
nsBoxFrame::Destroy 
[d:/BUILDS/tinderbox/Mozilla1.7/WINNT_5.0_Clobber/mozilla/layout/xul/base/src/nsBoxFrame.cpp,
line 1066]
nsFrameList::DestroyFrames 
[d:/BUILDS/tinderbox/Mozilla1.7/WINNT_5.0_Clobber/mozilla/layout/base/src/nsFrameList.cpp,
line 130]
nsContainerFrame::Destroy 
[d:/BUILDS/tinderbox/Mozilla1.7/WINNT_5.0_Clobber/mozilla/layout/html/base/src/nsContainerFrame.cpp,
line 166]
nsPositionedInlineFrame::Destroy 
[d:/BUILDS/tinderbox/Mozilla1.7/WINNT_5.0_Clobber/mozilla/layout/html/base/src/nsInlineFrame.cpp,
line 1104]
nsFrameManager::Destroy 
[d:/BUILDS/tinderbox/Mozilla1.7/WINNT_5.0_Clobber/mozilla/layout/html/base/src/nsFrameManager.cpp,
line 331]
PresShell::Destroy 
[d:/BUILDS/tinderbox/Mozilla1.7/WINNT_5.0_Clobber/mozilla/layout/html/base/src/nsPresShell.cpp,
line 1892]
PresShell::~PresShell 
[d:/BUILDS/tinderbox/Mozilla1.7/WINNT_5.0_Clobber/mozilla/layout/html/base/src/nsPresShell.cpp,
line 1644]
PresShell::`scalar deleting destructor'
PresShell::Release 
[d:/BUILDS/tinderbox/Mozilla1.7/WINNT_5.0_Clobber/mozilla/layout/html/base/src/nsPresShell.cpp,
line 1586]
nsCOMPtr_base::~nsCOMPtr_base 
[d:/BUILDS/tinderbox/Mozilla1.7/WINNT_5.0_Clobber/mozilla/xpcom/glue/nsCOMPtr.cpp,
line 82]
nsPrintObject::~nsPrintObject 
[d:/BUILDS/tinderbox/Mozilla1.7/WINNT_5.0_Clobber/mozilla/content/base/src/nsPrintObject.cpp,
line 84]
nsPrintEngine::Destroy 
[d:/BUILDS/tinderbox/Mozilla1.7/WINNT_5.0_Clobber/mozilla/content/base/src/nsPrintEngine.cpp,
line 299]
DocumentViewerImpl::Destroy 
[d:/BUILDS/tinderbox/Mozilla1.7/WINNT_5.0_Clobber/mozilla/content/base/src/nsDocumentViewer.cpp,
line 1199]
nsDocShell::Destroy 
[d:/BUILDS/tinderbox/Mozilla1.7/WINNT_5.0_Clobber/mozilla/docshell/base/nsDocShell.cpp,
line 3063]
nsWebShell::Destroy 
[d:/BUILDS/tinderbox/Mozilla1.7/WINNT_5.0_Clobber/mozilla/docshell/base/nsWebShell.cpp,
line 1271]
nsFrameLoader::Destroy 
[d:/BUILDS/tinderbox/Mozilla1.7/WINNT_5.0_Clobber/mozilla/content/base/src/nsFrameLoader.cpp,
line 373]
nsSubDocumentFrame::Destroy 
[d:/BUILDS/tinderbox/Mozilla1.7/WINNT_5.0_Clobber/mozilla/layout/html/document/src/nsFrameFrame.cpp,
line 567]
nsFrameList::DestroyFrame 
[d:/BUILDS/tinderbox/Mozilla1.7/WINNT_5.0_Clobber/mozilla/layout/base/src/nsFrameList.cpp,
line 214]
nsBoxFrame::RemoveFrame 
[d:/BUILDS/tinderbox/Mozilla1.7/WINNT_5.0_Clobber/mozilla/layout/xul/base/src/nsBoxFrame.cpp,
line 1118]
nsFrameManager::RemoveFrame 
[d:/BUILDS/tinderbox/Mozilla1.7/WINNT_5.0_Clobber/mozilla/layout/html/base/src/nsFrameManager.cpp,
line 758]
...

TB535594, TB537934:
0x00000000
nsIView::Destroy 
[d:/BUILDS/tinderbox/Mozilla1.7.2/WINNT_5.0_Clobber/mozilla/view/src/nsView.cpp,
line 253]
nsFrame::Destroy 
[d:/BUILDS/tinderbox/Mozilla1.7.2/WINNT_5.0_Clobber/mozilla/layout/html/base/src/nsFrame.cpp,
line 647]

-> Print Preview

Comment 5

[Jay Patel [:jay]]

Nicholas:  Are you still seeing this crash with the latest nightlies?  Bug
248825 was fixed recently on the Trunk and might have fixed your problem.

Comment 6

[Nicholas Shewmaker]

(In reply to comment #5)
It was still present in 1.7.3, but 1.8a4 build 2004092716 seems to work properly
for test case slashdot.org.

Comment 7

[Nicholas Shewmaker]

(In reply to comment #5)
Sorry. Scratch that. It worked once. Now, Slashdot's Print Preview opens in a
tab.  There is no way to exit Print Preview other than to close the tab, but at
least that no longer seems to cause a crash.  In the tabbed view, functions such
as page, Scale, and orientation are not available.
Again, it seems certain pages (try also m-w.com) open only in tabs, and others
preview as expected.

Comment 8

[Wayne Mery (:wsmwk)]

WFM 
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050307
Firefox/1.0+
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20050903
Firefox/1.6a1