Ctrl+= should enlarge text in Help viewer

RESOLVED FIXED

Status

RESOLVED FIXED
14 years ago
2 years ago

People

(Reporter: jwalden+fxhelp, Assigned: jwalden+fxhelp)

Tracking

({fixed-aviary1.0})

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

14 years ago
The problem's simple: in the Help viewer, pressing Ctrl+(plus key on qwerty
section of keyboard) doesn't work, while pressing Ctrl+(plus key on NumPad)
works.  Why?  The plus key on the qwerty section isn't really the plus key --
it's the equals (=) key.  Test it -- Ctrl+Shift+= will enlarge the text.

Firefox and Seamonkey have known about this problem for a while, so they've
added a second <key/> element that takes care of the = problem.  Patch coming up
to do the same for Help...note also that it's a l10n change because I have to
add = as an entity, so it needs to get in before PR1.0.
(Assignee)

Comment 2

14 years ago
Comment on attachment 156003 [details] [diff] [review]
Patch

Requesting review from rlk...
Attachment #156003 - Flags: review?(rlk)

Comment 3

14 years ago
Comment on attachment 156003 [details] [diff] [review]
Patch

r=rlk@trfenv.com, thanks Jeff! I would like an ID attribute but I guess it
isn't necessary.
Attachment #156003 - Flags: review?(rlk)
Attachment #156003 - Flags: review+
Attachment #156003 - Flags: approval-aviary?
(Assignee)

Comment 4

14 years ago
(In reply to comment #3)
> (From update of attachment 156003 [details] [diff] [review])
> r=rlk@trfenv.com, thanks Jeff! I would like an ID attribute but I guess it
> isn't necessary.

I was following the style that the main browser uses, which is not to assign an id:

http://lxr.mozilla.org/aviarybranch/source/browser/base/content/browser-sets.inc#285

I also figured the id would only be useful if it were hooked up to something, as
the id is hooked up to the relevant menu item in the main browser.
Status: NEW → ASSIGNED

Comment 5

14 years ago
Not a doc change, so removing bug dependency.
No longer blocks: 253104
(Assignee)

Comment 6

14 years ago
We're adding an entity for l10n...requesting blocking-aviary1.0PR.
Flags: blocking-aviary1.0PR?
Whiteboard: [have patch]

Updated

14 years ago
Flags: blocking-aviary1.0PR? → blocking-aviary1.0PR+

Comment 7

14 years ago
Comment on attachment 156003 [details] [diff] [review]
Patch

approved. but needs to get in quickly
Attachment #156003 - Flags: approval-aviary? → approval-aviary+
(Assignee)

Comment 8

14 years ago
> (From update of attachment 156003 [details] [diff] [review])
> approved. but needs to get in quickly

Steffen, any chance you can check this in?

Comment 9

14 years ago
Steffen got it. This is in on the trunk, so fixed.
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED

Comment 10

14 years ago
Checked in br & trunk. I also added an id key_textZoomEnlarge2 just in case an
extension wants to change it.
Keywords: fixed-aviary1.0
Whiteboard: [have patch]
Target Milestone: --- → Firefox1.0beta

Updated

14 years ago
Component: Help Viewer → Help Viewer
Flags: review+
Flags: blocking-aviary1.0PR+
Flags: approval-aviary+
Product: Firefox → Toolkit
Target Milestone: Firefox1.0beta → ---
Product: Toolkit → Seamonkey
You need to log in before you can comment on or make changes to this bug.