Closed Bug 255571 Opened 20 years ago Closed 20 years ago

Right-click context menu cut off/disappearing/offscreen when it contains too many items (items added by extensions)

Categories

(Firefox :: Menus, defect)

Product:
Firefox
Component:
Menus
Platform:
x86
All
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
VERIFIED DUPLICATE of bug 245163

People

(Reporter: Noah, Assigned: bugzilla)

References

(
URL
)

Details

User-Agent:       Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:1.7.2) Gecko/20040812 Firefox/0.9
Build Identifier: Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:1.7.2) Gecko/20040812 Firefox/0.9

Try highlighting a link that's as close to the tabs or location bar as you can
get it (try positioning the page) then right-click it. You'll see. You can also
refer to my url to see a live screenshot of this in action.

I've had deeper thought on this and I believe it may be caused by extensions
altering the context menu and Firefox not being able to compensate. If too many
entries are added to the menu, I believe that what Firefox thought had fixed [I
believe this problem exisited earlier but was addressed] would simply be
rebroken when another item was added to the context menu [I believe you have to
go over a certain number to accomplish this, not just one].

So, does the problem there in lie within the extensions or Firefox?
****************************
Another unexpected bug captured in the screenshot; have no idea how to re-create
or label: I circled the top because somehow I've managed to blank out
access/grey out/remove focus from all those menu items above the Navigation
Toolbar including Help. Yes, I'm in only one window and it's active. And, no it
wasn't because I was having a context menu out at the time as the problem
remained after I closed it [the context menu]. Upon exiting all browsers and
opening a new one problem disappeared. Thought it was worth noting though. I
also believe I had installed Cusser's Image Toolbar 3.1+ extension at the time
and hadn't restarted Firefox [all day] in order to allow the extension to
install. I believe that may be partly why for the greyed out menu items.

Reproducible: Always
Steps to Reproduce:
1.Read above for steps
2.
3.

Actual Results:  
The bug error as I described it.

Expected Results:  
It should have compensated for however many the number of menu items were in the
context menu and the position of the right-click to allow the correct
reshufflement and allow all items on the context menu to be displayed without
being hidden in any way.

Using Noia Theme 2.7. Have not tried removing it and testing; will do so shortly.
Confirmed: It IS a theme conflict. Haven't tested other themes but I would guess
they experience the same problem. To reiterate: DEFAULT THEME DOES NOT
EXPERIENCE THIS BUG.

Current theme: Noia 2.0 (eXtreme) 2.7
This means you have to talk to the theme owner.
Setting ->INVALID
Status: UNCONFIRMED → RESOLVED
Closed: 20 years ago
Resolution: --- → INVALID
Thought I'd comment upgrading to ver. 2.72 did not resolve problem.
Behavior will not appear on default theme with proposed example instead one must
be in a text box must like the one I'm using to write this now. Move it as near
as you can to the location bar [what have you] and highlight a bit of text
you've entered. Right-click it, you should get my results...

Last updated: Sun, 22 Aug 2004 19:30:31 GMT

User Agent: Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:1.7.2)
Gecko/20040821 Firefox/0.9

*** Extensions (enabled: 31, disabled: 4):
ieview 0.8 (beta)
Clone Window 0.2.3
Popup Count 0.2.5
Popup Allow 0.2.1
keyconfig 20040617
DictionarySearch 0.6.3
TinyUrl Creator 0.6
Adblock 0.5.2+
Download Statusbar 0.9.1
Enhanced History Manager 0.4.1
ChatZilla 0.9.64e
Show Image 0.2.1
BBCode 0.2.9
Search Button 0.4.2
Image Toolbar 0.3.1 [disabled]
Open Long Url 0.1
Copy Plain Text 0.1
JavaScript Console Status 1.5 [disabled]
Browser Uptime 1.5.1
Plain Text Links 0.2 [disabled]
QuickNote 0.5.9.2
Scribe 0.2
InfoLister 0.4 *added recently can not be culprit*
EMbuttons 0.10.4
Download Manager Tweak 0.5.1 [disabled]
Advanced Highlighter Button 1.3
mozImage 0.9.0
Make Link 1.2 *added recently can not be culprit*
Paste User Agent 0.1 *added recently can not be culprit*
SpellBound 0.6.0
Tab X 0.2 *added recently can not be culprit*
Show Old Extensions 0.1.6 *added recently can not be culprit*
Menu Editor 1.0 *added recently can not be culprit*
Configuration Mania 1.03.2.0033 *added recently can not be culprit*
Nuke Anything 0.2 *added recently can not be culprit*

*** Themes (2):
Noia 2.0 (eXtreme) 2.73
Firefox (default) 2.0 [selected]
Status: RESOLVED → UNCONFIRMED
Resolution: INVALID → ---
Proof of occurence with Default theme:
http://home.ripway.com/2004-5/120664/proof.jpg

It seems moving the text box as close as possible doesn't repeat the problem
[now I understand why I couldn't reproduce it the first time], it's an odd space
between it [the text box] and location bar I can't seem to specify. I thought I
was going crazy when I couldn't reproduce the bug.

Like I was saying, could this be a result of extensions altering the context menu?
So far the ones I know of are BBCode, QuickNote, SpellBound and DictionarySearch.
Summary: Right-click context menu cut off by disappearing [becoming hidden] underneath all toolbars and tabs? → Right-click context menu cut off/disappearing by exceeding screen resolution?
This may be caused by the extensions making the menu larger, and the menu
positioning code not realizing this and having the menu appear off screen.

Can you reproduce with all extensions disabled (start firefox with -safe-mode)?

http://kb.mozillazine.org/index.phtml?title=Safe_Mode_(Firefox)
(In reply to comment #6)
> This may be caused by the extensions making the menu larger, and the menu
> positioning code not realizing this and having the menu appear off screen.
> 
> Can you reproduce with all extensions disabled (start firefox with -safe-mode)?
> 
> http://kb.mozillazine.org/index.phtml?title=Safe_Mode_(Firefox)
Good idea but proved ineffective as no entries other that the default were
listed on the context menu. So... how could the menu exceed any length? Ex. Cut,
Copy Paste, Delete are not enough to replicate problem.

Though, this leads me even further to believe my original assumption. I'll start
uninstalling extensions believed to be the culprit one by one.
> Cut, Copy Paste, Delete are not enough to replicate problem

That's what I wanted to confirm. And you did, thank you ;).

Please, do see if you can narrow it down to a certain extension.
Whoo! I tried disabling many extensions believed to be the cause and restarted 
FF over and over again. I became frustrated and finally started uninstalled the 
suspecting ones in case they had somehow corrupted the menu. I unistalled many 
to no avail UNTIL I finally messed with one extension I thought did not have a 
shot since it [I thought] was newly installed after the bug started appearing - 
I was wrong...

THE CULPRIT: MAKE LINK 1.0!!!!!!!!!!!
Even upgrading over it to 2.0 had no change. It was not until I uninstalled it 
did the symptoms go away; disabling it may have stopped the symptoms as well 
but I was frustrated already. Why continue to disable extensions when they 
weren't performing the results I wanted? That, and they could've corrupted the 
menu anyway.

Now, I have will a lingering hate for the man who created this extension. While 
I do love it, and it is an absolute must have for me! He put me through torture 
and pain while I tried to endure this bug for an entire month [and change] now! 
And, to add, I use the context menu much more than the above-average user.

I hope this helps anyone for future reference. I'll be contacting the maker of 
Make Link now; if now installing a clean 2.0 doesn't work and brings back that 
god awful bug. *Anger* Wish me luck!
Status: UNCONFIRMED → RESOLVED
Closed: 20 years ago → 20 years ago
Resolution: --- → FIXED
Marking FIXED.
OS: Windows ME → All
Not fixed. It's caused by an extension, but it still shouldn't happen.
Status: RESOLVED → UNCONFIRMED
Resolution: FIXED → ---
*** Bug 269758 has been marked as a duplicate of this bug. ***
Severity: normal → minor
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: Right-click context menu cut off/disappearing by exceeding screen resolution? → Right-click context menu cut off/disappearing/offscreen when it contains too many items (items added by extensions)
Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:1.7.3) Gecko/20041001
Firefox/0.9 - And, I still experience this.
FYI: The 9.0 was mistakenly unchanged to *1.0 or .10 [*whatever, the deveopers
could never make up their minds] in this odd, obsecure nightly build, in case
anyone was wondering ;)

You're right, Gavin. I originally assumed this but no one could validate or
attempted to validate my claim. On the "extensions causing this error" end. I'm
quite tired of this bug and I'm not going to check if MakeLink fixes it for me
or not anymore. I've grown so tired of the bug [FYI: I finally caved and
installed ML 2.0 shortly after marking this bug fixed] I've learned to endure
it. But now Gavin as you speak, I hear this this problem is not one-extension
limited for the first time, which I originally believed - that it wasn't. But
out of all my extensions, I could only trace it back to Make Link and BBCode. 

But, I KNEW there had to be consequences for many extensions occupying the
context menu or power-freak extension users who would clutter their context menu
with simply too many context menu hogging extensions per screen resolution! I
believe that it also goes hand-in-hand with screen resolution. As someone like
me (800X600) vs. 1024 X 768, etc. could not stand a chance at doubling, tripling
the amount of context menu items to be displayed cleanly.

Well, Gavin, what does the resolution entail? Possible user-end discretion - As
to choose a limited number of extensions to occupy the context menu? Because as
I see it, per resoltuion, no matter what kind of fix Firefox applies, some kind
of off-screen menu is going to occur when it has too many entries. Unless we
propose a cacading context menu? Hahaha. < I'm laughing at the thought of such a
thing. Would the creators actually honor a cascading menu request? I doubt it.
It would be very interesting to see in action though, if I might say.
For what it's worth, I have this problem also, and I don't even have MakeLink
installed, nor have I ever installed it.

As far as how to handle it, might I suggest something similar to what IE (gasp!)
does: it tries hard to fit the menu on the screen as much as possible (Firefox
1.0 does not do this), but if it cannot do so, it chops the menu off and adds a
scroll arrow button as the topmost/bottommost item in the menu.  This way, the
menu doesn't suddenly double in width, but all the items in it are still accessible.
Coincidentally this has happened before during this bug in earlier nightly 
builds but since this lastest one 10/10, it has not happened. I too, thought 
again, damn this must be another bug inside a bug as it was mimicking the 
Bookmarks menu dropdown having a scroll up arrow and scroll down arrow inside 
the context menu? Maybe it was a feature/patch they decided to pull out at the 
last minute. Who knows?

It's a good idea but I wouldn't want to have to scroll EVERYTIME I wanted to 
get something at the bottom of the list. That would drive me up the walls.
This unintended behavior occurs on MacOS X also when several extensions are
installed.
I think there are two issues here:
1) The context menu is sometimes misplaced. This a both Seamonkey and Firefox
issue and bug 267821 is much more clear about it (see comments and attachments).

2) There isn't any mechanism for handling the context menu when it gets too big
to fit in the screen due to extensions, even if it's correctly placed. This is
mainly a Firefox issue (but can also happen in Seamonkey).

Thus, I think the best would be to use this bug for the second issue and mark it
as dependant of bug 267821 for the first issue.

The second issue it not a theme issue neither an extensions issue, but a Firefox
one, which is not well prepaired for handling expanded context menus.
A solution could be to group the items added by extensions inside an
"extensions" submenu when the number of added items is bigger than X (a number
which could be either resolution dependant, either choosed by the user - I
prefer the second way) AND show in the main context menu the last Y (choosed by
the user) used extension entries.

So my proposal would be something like:
*******************************
* Undo			
* Redo
*------------------------------
* Cut
* Copy
* Paste
* Delete
*------------------------------
* Select All
*------------------------------
* Last used extension item #1
* Last used extension item #2
* ...
* Last used extension item #Y
*------------------------------
* All extensions items ->	*********************
*******************************	* Extension 1 item 1
				* Extension 1 item 2
				* Extension 1 item 3
				*--------------------
				* Extension 2 item 1
				* Extension 2 item 2
				*--------------------
				* Extension 1 item 1
				*--------------------
				* ....
				*--------------------
				* Extension N item P
				*********************

In the extreme case the extensions menu gets so bigger that it doesn't fit the
screen, it could be made scrollable (like the bookmarks menus is Seamonkey).

*** This bug has been marked as a duplicate of 245163 ***
Status: NEW → RESOLVED
Closed: 20 years ago → 20 years ago
Resolution: --- → DUPLICATE
Status: RESOLVED → VERIFIED
QA Contact: bugzilla → menus
You need to log in before you can comment on or make changes to this bug.