255572 - "Restore Default" in customize toolbars window should restore display mode

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Blake Ross]

Currently, Restore Default only restores the buttons. It should also restore
back to small icons / no text mode.

Comment 1

[Blake Ross]

Steffen, any chance you can get to this for 1.0?

Comment 2

[Steffen Wilberg]

Attachment: like this

Comment 3

[Steffen Wilberg]

Comment on attachment 156101 [details] [diff] [review]
like this

Some comments:

>-const kWindowWidth = 600;
>+const kWindowWidth = 635;
This fixes bug 245088 (look at the first screenshot in that bug).

>-  if (aModeValue == "text") {
>-    iconSizeCheckbox.disabled = true;
>-    iconSizeCheckbox.checked = false;
>-  }
>-  else {
>-    iconSizeCheckbox.disabled = false;
>-    iconSizeCheckbox.checked = gToolboxIconSize;
>-  }
>+  iconSizeCheckbox.disabled = aModeValue == "text";
This is bogus. Changing to text mode shouldn't reset the checkbox, only disable
it. And don't mess around with the checkbox when switching between Icons to
Icons and Text either.

Comment 4

[Steffen Wilberg]

Blake said he wants this for 1.0, so requesting blocking-aviary1.0. Patch is
awaiting review.

Comment 5

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 156101 [details] [diff] [review]
like this

r+a=[e-mail]

Comment 6

[Steffen Wilberg]

Checked in br & trunk.

Comment 7

[Tracy Walker [:tracy]]

verified fixed as seen on Windows 2004-10-07-06-0.9,  Mac 2004-10-07-05-0.9 and
linux 2004-10-07-09-0.9

note: original comment "It should also restore back to small icons / no text mode." 

The current default is normal icons no text.  Which this does revert back to on
Restore Default.

Comment 8

[Steffen Wilberg]

Oops, that's true. But icons *are* large in new profiles, so I'm happy with the
Restore Default button restoring large icons.