255605 - [Linux] crash when manually opening a popup, having Google Pagerank installed and disabled [@ nsImageBoxFrame::UpdateImage() ]

Status: RESOLVED WORKSFORME

(Firefox :: General, defect)

Description

[Angelo]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.2) Gecko/20040813 Firefox/0.9.1+
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.2) Gecko/20040813 Firefox/0.9.1+

When trying to manually open a blocked popup from whatever site it results in a
crash.
This crash happens only when Google pagerank extension is enabled but not always.

Reproducible: Sometimes
Steps to Reproduce:
1. Go to the supplied url
2. Manually open popup when blocked

Actual Results:  
Crash

Expected Results:  
Open popup blocked

Installed extensions:
- googlebar 0.9.0.28
- All-in-One Gestures 0.12.1
- FLST 0.6
- Tabbrowser Preferences 0.6.7
- Adblock v.5 d2 nightly 39
- GooglePreview 0.3
- GooglePagerank 0.8
- WebDeveloper 0.8

Comment 1

[Angelo]

I was able to reproduce the bug in a new profile using only:
- Google Pagerank 0.8

1. set user_pref("dom.disable_window_open_feature.status",false) or via
preferences->web features->javascript advanced->Hide status bar Checked (can
hide status bar)

2. disable google pagerank by left-clicking in the status bar

3. restart firefox

4. go to the url supplied and try to manually open the popup

Comment 2

[Angelo]

google pagerank 0.8 can be found at http://pagerankstatus.mozdev.org/

Comment 3

[Angelo]

Talkback incident ID: TB559629G
http://talkback-public.mozilla.org/talkback/fastfind.jsp?search=2&type=iid&id=TB559629G

Comment 4

[Steffen Wilberg]

Crashes here as well when following the instructions in comment 1. Mozilla/5.0
(X11; U; Linux i686; en-US; rv:1.7.2) Gecko/20040814 Firefox/0.9.1+ (Steffen).

This is really an edge case since you have to install the Google Pagerank
extension, disable it, and also allow sites to hide the status bar, which is now
disabled by default.

But no extension should be able to crash Firefox, so this is a Firefox bug.
Confirming and tweaking summary.

Comment 5

[Olivier Cahagne]

Just had this crash with FF 0.10.1 fresh install on RHEL 3.0:
http://talkback-public.mozilla.org/talkback/fastfind.jsp?search=2&type=iid&id=tb1193251m
URL: http://www.bmw.fr/ (popup blocker enabled), then clicking in top menu "M5".

Comment 6

[Asa Dotzler [:asa]]

Please file this bug on the Google Page Rank extension. Thanks.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Actually, comment 4 is right -- extensions should not crash like this.  That
said, is this an issue with trunk builds?

Comment 8

[Steffen Wilberg]

I just tried to reproduce the steps in comment 1, using Mozilla/5.0 (Windows; U;
Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050329 Firefox/1.0+ and Google Pagerank
Status 0.9.3.

> 2. disable google pagerank by left-clicking in the status bar
This is now right-click.

> 4. go to the url supplied and try to manually open the popup
I clicked on "Click here to START the pop up test". The test started, the
blocked popup icon was shown in the status bar, but no popups were listed in its
menu, so I couldn't open the popup manually. This works fine on e.g.
http://www.popuptest.com/popuptest1.html.

Comment 9

[Angelo]

Tested with latest nightly and it doesn't crash anymore

btw closing a crash bug because caused by an extension isn't actually the best
practice..

Comment 10

[Steffen Wilberg]

-> WFM.