255610 - document.implementation.hasFeature('XHTML', '2.0') should return true

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Martin Honnen]

The DOM Level 2 HTML specification in its introduction at
  http://www.w3.org/TR/DOM-Level-2-HTML/html.html#ID-1176245063
says the following about feature strings:

  A DOM application may use the hasFeature(feature, version) method of the
DOMImplementation interface with parameter values "HTML" and "2.0"
(respectively) to determine whether or not this module is supported by the
implementation. In addition to the feature string "HTML", the feature string
"XHTML" (version string "2.0") can be used to check if the implementation
supports XHTML (this is equivalent to checking the features "XML" and "HTML").

As Mozilla supports XHTML and furthermore returns true for the feature/version
'HTML'/'2.0' and 'XML'/'2.0' it should return true from
  document.implementation.hasFeature('XHTML', '2.0') 
but returns false.

Tested with Mozilla 1.8a3
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a3) Gecko/20040813.

I will upload a test case which demonstrates the results Mozilla returns for the
relevant DOM feature/version combinations.

Comment 1

[Martin Honnen]

Attachment: test case that shows output of document.implementation.hasFeature('XHTML', '2.0')

Comment 2

[Martin Honnen]

The hasFeature method is implemented here:
http://lxr.mozilla.org/seamonkey/source/content/base/src/nsDocument.cpp#331
and calls the InternalIsSupported method implemented here:
http://lxr.mozilla.org/seamonkey/source/content/base/src/nsGenericElement.cpp#1134
so all that probably needs to changed is some hard-coded check for XHTML, 2.0 as
follows

} else if (PL_strcasecmp(f, "Views") == 0 ||
              PL_strcasecmp(f, "StyleSheets") == 0 ||
              PL_strcasecmp(f, "Core") == 0 ||
              PL_strcasecmp(f, "CSS") == 0 ||
              PL_strcasecmp(f, "CSS2") == 0 ||
              PL_strcasecmp(f, "Events") == 0 ||
 //           PL_strcasecmp(f, "UIEvents") == 0 ||
              PL_strcasecmp(f, "MouseEvents") == 0 ||
              PL_strcasecmp(f, "MouseScrollEvents") == 0 ||
              PL_strcasecmp(f, "HTMLEvents") == 0 ||
              PL_strcasecmp(f, "Range") == 0 ||
              PL_strcasecmp(F, "XHTML") == 0) {
     if (aVersion.IsEmpty() ||
         PL_strcmp(v, "2.0") == 0) {
       *aReturn = PR_TRUE;
     }
   } 

Comment 3

[Martin Honnen]

I made a typo in the previous comment, code should be

} else if (PL_strcasecmp(f, "Views") == 0 ||
              PL_strcasecmp(f, "StyleSheets") == 0 ||
              PL_strcasecmp(f, "Core") == 0 ||
              PL_strcasecmp(f, "CSS") == 0 ||
              PL_strcasecmp(f, "CSS2") == 0 ||
              PL_strcasecmp(f, "Events") == 0 ||
 //           PL_strcasecmp(f, "UIEvents") == 0 ||
              PL_strcasecmp(f, "MouseEvents") == 0 ||
              PL_strcasecmp(f, "MouseScrollEvents") == 0 ||
              PL_strcasecmp(f, "HTMLEvents") == 0 ||
              PL_strcasecmp(f, "Range") == 0 ||
              PL_strcasecmp(f, "XHTML") == 0) {
     if (aVersion.IsEmpty() ||
         PL_strcmp(v, "2.0") == 0) {
       *aReturn = PR_TRUE;
     }
   } 

Comment 4

[Anne (:annevk)]

Mozilla doesn't support XHTML 2.0. XHTML 2.0 isn't anywhere near recommendation
yet, I suspect this is invalid.

Comment 5

[Hixie (not reading bugmail)]

This has nothing to do with XHTML 2.0.

Comment 6

[Martin Honnen]

The bug is not about XHTML 2.0 support but about DOM support for the defined DOM
feature XHTML for the DOM Level 2.0.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Anne, care to test and post the patch?

Comment 8

[Vidar Haarr (not reading bugmail)]

Attachment: patch to that effect

Patches nsGenericElement.cpp to include XHTML check.

The testcase in this bug returns true in the last check on Firefox trunk with
this patch.

Comment 9

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 169238 [details] [diff] [review]
patch to that effect

r=bzbarsky.  jst, could you sr?

Comment 10

[Johnny Stenback (:jst)]

Comment on attachment 169238 [details] [diff] [review]
patch to that effect

sr=jst

Comment 11

[Vidar Haarr (not reading bugmail)]

Thanks for the reviews.
Attachment 169238 [details] [diff] checked in to seamonkey trunk by bernd.
-> FIXED.