255623 - Punctuation fix: Popup should be Pop-up

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Jeremy M. Dolan]

The pop-up blocker refers to a window.open'd window as a "popup". Is that
pronounced "PO pup"? "POP up"? "po PUP?" Hyphens have very good reasons for
existing, and one of them is for situations EXACTLY such as this. Clarifying
pronunciation for compound words.

Yes, "popup" may be immediately recognizable to you and I. You've probably never
realized how ambiguous a stream of letters those three p's and two vowels are
because of your familiarity. That doesn't make it good form; grammar should
serve to make language as readable as possible to as many people as possible. I
know we consider ourselves on the cutting edge of browser development here, but
we're not on the cutting edge of punctuation as well; we can't make up new words
for old things, or just startrunning wordstogether willynilly.

Merriam Webster, American Heritage, XP SP2, and my spell-checker all agree:
pop-up is the word. Clearer, cleaner, correcter.

Comment 1

[Kevin Brosnan]

Attachment: hyphenates occurrences of popup and popups

Cleans up all (I think) occurrences of popup and popups in Firefox.

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 291914 [details] [diff] [review]
hyphenates occurrences of popup and popups

a=drivers for after Firefox 3 Beta 2 freeze

Comment 3

[Reed Loden [:reed]]

Comment on attachment 291914 [details] [diff] [review]
hyphenates occurrences of popup and popups

Maybe Mano has time for this super-simple patch?

Comment 4

[Asaf Romano (gone)]

Comment on attachment 291914 [details] [diff] [review]
hyphenates occurrences of popup and popups

r=mano

Comment 5

[Reed Loden [:reed]]

Checking in browser/locales/en-US/chrome/browser/browser.dtd;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/browser.dtd,v  <--  browser.dtd
new revision: 1.82; previous revision: 1.81
done
Checking in browser/locales/en-US/chrome/browser/browser.properties;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/browser.properties,v  <--  browser.properties
new revision: 1.54; previous revision: 1.53
done
Checking in browser/locales/en-US/chrome/browser/pageInfo.dtd;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/pageInfo.dtd,v  <--  pageInfo.dtd
new revision: 1.25; previous revision: 1.24
done
Checking in browser/locales/en-US/chrome/browser/pageReport.dtd;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/pageReport.dtd,v  <--  pageReport.dtd
new revision: 1.3; previous revision: 1.2
done
Checking in browser/locales/en-US/chrome/browser/pageReportFirstTime.dtd;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/pageReportFirstTime.dtd,v  <--  pageReportFirstTime.dtd
new revision: 1.4; previous revision: 1.3
done
Checking in browser/locales/en-US/chrome/browser/preferences/preferences.properties;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/preferences/preferences.properties,v  <--  preferences.properties
new revision: 1.22; previous revision: 1.21
done
Checking in browser/locales/en-US/chrome/help/accessibility.xhtml;
/cvsroot/mozilla/browser/locales/en-US/chrome/help/accessibility.xhtml,v  <--  accessibility.xhtml
new revision: 1.4; previous revision: 1.3
done
Checking in browser/locales/en-US/chrome/help/firebird-toc.rdf;
/cvsroot/mozilla/browser/locales/en-US/chrome/help/firebird-toc.rdf,v  <--  firebird-toc.rdf
new revision: 1.66; previous revision: 1.65
done
Checking in browser/locales/en-US/chrome/help/forieusers.xhtml;
/cvsroot/mozilla/browser/locales/en-US/chrome/help/forieusers.xhtml,v  <--  forieusers.xhtml
new revision: 1.20; previous revision: 1.19
done
Checking in browser/locales/en-US/chrome/help/popup.xhtml;
/cvsroot/mozilla/browser/locales/en-US/chrome/help/popup.xhtml,v  <--  popup.xhtml
new revision: 1.18; previous revision: 1.17
done
Checking in browser/locales/en-US/chrome/help/using_firebird.xhtml;
/cvsroot/mozilla/browser/locales/en-US/chrome/help/using_firebird.xhtml,v  <--  using_firebird.xhtml
new revision: 1.45; previous revision: 1.44
done

Comment 6

[Kevin Brosnan]

Attachment: more corrections

More corrections.

Comment 7

[Reed Loden [:reed]]

Checking in browser/locales/en-US/chrome/browser/pageReport.dtd;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/pageReport.dtd,v  <--  pageReport.dtd
new revision: 1.4; previous revision: 1.3
done
Checking in browser/locales/en-US/chrome/browser/pageReportFirstTime.dtd;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/pageReportFirstTime.dtd,v  <--  pageReportFirstTime.dtd
new revision: 1.5; previous revision: 1.4
done
Checking in browser/locales/en-US/chrome/browser/preferences/preferences.properties;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/preferences/preferences.properties,v  <--  preferences.properties
new revision: 1.23; previous revision: 1.22
done
Checking in browser/locales/en-US/chrome/help/accessibility.xhtml;
/cvsroot/mozilla/browser/locales/en-US/chrome/help/accessibility.xhtml,v  <--  accessibility.xhtml
new revision: 1.5; previous revision: 1.4
done
Checking in browser/locales/en-US/chrome/help/firebird-toc.rdf;
/cvsroot/mozilla/browser/locales/en-US/chrome/help/firebird-toc.rdf,v  <--  firebird-toc.rdf
new revision: 1.67; previous revision: 1.66
done
Checking in browser/locales/en-US/chrome/help/popup.xhtml;
/cvsroot/mozilla/browser/locales/en-US/chrome/help/popup.xhtml,v  <--  popup.xhtml
new revision: 1.19; previous revision: 1.18
done
Checking in browser/locales/en-US/chrome/help/search-db.rdf;
/cvsroot/mozilla/browser/locales/en-US/chrome/help/search-db.rdf,v  <--  search-db.rdf
new revision: 1.4; previous revision: 1.3
done