255655 - [Approval Queue] Denying an upload does not delete the version

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[alanjstr]

The entry from t_version is not removed when you deny someone's request.

Comment 1

[Wolf [:wolf]]

No it isn't.. It's marked as approved=no. :-) Are you expecting it to delete the
record entirely?

Comment 2

[alanjstr]

Actually, yes.  Otherwise when they upload another one, they wind up with rows
of FFMMTT

Comment 3

[Wolf [:wolf]]

If the record is removed, where's the discoverable UI on the website showing
that it was denied? ;-)

Comment 4

[alanjstr]

t_approvallog, of course.

Comment 5

[Wolf [:wolf]]

Comment #2 addressed a bug in additem actually thats been fixed. There's
currently no link from the overview page to t_approvallog and not much to go on
w/o the t_version record that matched up to it (as t_al intentionally records
the id/vid of the t_v record.)

Most cases for denial will be a situation that's corrected, and the item is
resubmitted, (upon resubmittal the duplicate old record would be removed anyway).

The only thing I can think of here that's needed is to make sure any files are
deleted so that only the DB record remains.

Comment 6

[Wolf [:wolf]]

Woo, set URI to null and delete the item from the approval files directory.

Comment 7

[Wolf [:wolf]]

Bulk Moving Developer Control Panel bugs to new component.
(Filter: massdevcpspam)

Comment 8

[alanjstr]

Mass-resolving bugs that have been fixed on trunk.

Comment 9

[Wolf [:wolf]]

Sorry for the bugspam, reopening bugs wrongly marked as resolved.