Closed Bug 255664 Opened 20 years ago Closed 20 years ago

SQL errors during buglist cause an almost blank ("</p>") error page

Categories

(Bugzilla :: Query/Bug List, defect)

Product:
Bugzilla
Component:
Query/Bug List
Version:
2.19
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Bugzilla 2.18

People

(Reporter: justdave, Assigned: justdave)

Details

Attachments

(1 file)

Patch v1
2.07 KB, patch
myk
: review+
Details | Diff | Splinter Review 
Browser window shows only:

------cut here------
</p>
------cut here------

View source shows:

------cut here------
WARNING: YOUR BROWSER DOESN'T SUPPORT THIS SERVER-PUSH TECHNOLOGY.
--------- =_aaaaaaaaaa0
Content-Type: text/html

<html>
  <head>
    <title>Bugzilla is pondering your query</title>
  </head>
  <body>
    <h1 style="margin-top: 20%; text-align: center;">Please stand by ...</h1>


  </body>
</html>
--------- =_aaaaaaaaaa0
<h1>Software error:</h1>
<pre>DBD::mysql::st execute failed: Column: 'creation_ts' in where clause is
ambiguous [for statement ``SELECT bugs.bug_id, bugs.bug_severity, bugs.priority,
bugs.bug_status, bugs.resolution, bugs.delta_ts, bugs.bug_severity,
bugs.priority, map_assigned_to.login_name, bugs.bug_status, bugs.resolution,
map_components.name, bugs.target_milestone, bugs.status_whiteboard,
bugs.short_desc FROM bugs, profiles AS map_assigned_to, components AS
map_components, attachments attachments_0 LEFT JOIN bug_group_map  ON
bug_group_map.bug_id = bugs.bug_id  AND bug_group_map.group_id NOT IN
(9,5,10,3,2,1,11,4,14,16,13,12,6,8,7)  LEFT JOIN cc ON cc.bug_id = bugs.bug_id
AND cc.who = 10297 WHERE bugs.assigned_to = map_assigned_to.userid AND
bugs.component_id = map_components.id AND ((creation_ts &gt;= '2003-01-01
00:00:00')) AND bugs.bug_id = attachments_0.bug_id AND (bugs.product_id IN (21))
AND (bugs.resolution IN ('FIXED')) AND (attachments_0.ispatch = '1') AND
((bug_group_map.group_id IS NULL)    OR (bugs.reporter_accessible = 1 AND
bugs.reporter = 10297)     OR (bugs.cclist_accessible = 1 AND cc.who IS NOT
NULL)     OR (bugs.assigned_to = 10297) OR (bugs.qa_contact = 10297) ) GROUP BY
bugs.bug_id ORDER BY bugs.bug_status, bugs.priority, map_assigned_to.login_name,
bugs.bug_id '']) at Bugzilla/DB.pm line 66
	Bugzilla::DB::SendSQL('SELECT bugs.bug_id, bugs.bug_severity, bugs.priority,
bugs.bug_s...') called at /opt/webtools/bugzilla/buglist.cgi line 695
</pre>
<p>
For help, please send mail to the webmaster (<a
href="mailto:webmaster@mozilla.org">webmaster@mozilla.org</a>), giving this
error message 
and the time and date of the error.


</p>
------cut here------

As you can see, the first part was closed before the error occurred, and the
error handler said "oh, headers have already been sent" so it didn't send any.
Attached patch Patch v1 — — Splinter Review 
This should apply cleanly to both tip and 2.18.  This problem does not exist in
2.16, I believe it was introduced with the switch to using CGI.pm.
Attachment #156138 - Flags: review?(myk)
Target Milestone: --- → Bugzilla 2.18
Flags: blocking2.18+
Comment on attachment 156138 [details] [diff] [review]
Patch v1

Works, looks good. r=myk
Attachment #156138 - Flags: review?(myk) → review+
Flags: approval2.18+
Flags: approval+
Whiteboard: patch awaiting checkin
Checking in buglist.cgi;
/cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v  <--  buglist.cgi
new revision: 1.261; previous revision: 1.260
done

2.18 branch:

Checking in buglist.cgi;
/cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v  <--  buglist.cgi
new revision: 1.255.2.2; previous revision: 1.255.2.1
done
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Whiteboard: patch awaiting checkin
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: