Closed
Bug 25573
Opened 25 years ago
Closed 23 years ago
Msg Compose-UI clean up
Categories
(MailNews Core :: Composition, defect, P3)
Tracking
(Not tracked)
VERIFIED
FIXED
Future
People
(Reporter: jglick, Assigned: andreww)
Details
(Keywords: polish, Whiteboard: [nsbeta1+ 2/13])
Attachments
(6 files)
4.53 KB,
patch
|
Details | Diff | Splinter Review | |
4.67 KB,
patch
|
Details | Diff | Splinter Review | |
1020 bytes,
patch
|
Details | Diff | Splinter Review | |
4.72 KB,
patch
|
Details | Diff | Splinter Review | |
507 bytes,
patch
|
Details | Diff | Splinter Review | |
28.23 KB,
image/gif
|
Details |
Toolbar buttons should be spaced as follows (| indicates a space): Send | Address Attach Quote Spelling | Save Print Stop This window could use some cleaning up and made to look more like the UE spec if possible. Should have the rounded corners on text fields (like the browser URL field does). Top of Attachments field should be even with top of Addressing area. Bottom of Attachments field should be even with bottom of Subject area. http://gooey/client/5.0/specs/mail/Compose/Compose.html#Cheatsheet
Updated•25 years ago
|
QA Contact: lchiang → nbaca
Comment 2•25 years ago
|
||
Did first part. Add separators in the button toolbar.
Comment 4•24 years ago
|
||
Mass moving to M16 to get these off the M15 radar. Please let me know if this is really an M15 stopper.
Target Milestone: M15 → M16
Comment 5•24 years ago
|
||
Not beta2 stopper. Marking M18.
OK :-( This window really needs to be cleaned up for the final release. Non-technical users will base their impressions on how the product looks and this is a very frequently used window. The UI for this window seems a little behind the other major windows.
Spaces between items in the toolbar no longer seem to be present. 6-21-2000-M17 Toolbar buttons should be spaced as follows (| indicates a space): Send | Address Attach Quote Spelling | Save Stop
Comment 10•24 years ago
|
||
Moving nsbeta3 keyword nomination from Status Whiteboard to Keyword field. Put in wrong field. :-(
Keywords: nsbeta3
Whiteboard: nsbeta3
Reporter | ||
Comment 11•24 years ago
|
||
Update with Priorities (P) based on UE review meetings: Send | Address Attach Quote Spell | Save Stop (P4) Text Field corners should have the rounded corners (like the browser URL field does). (P5) Attachment area should be aligned with the top of the addressing area and the bottom of the subject text field. (P3)
Reporter | ||
Comment 12•24 years ago
|
||
Additionally, the Attachment area looks a little weird with only the top part of the area outlined in black. Maybe the whole attachment area should be outlined with a black line (so it matches the addressing area)? Or a slight 3d look like the Subject text field?
Reporter | ||
Comment 16•24 years ago
|
||
Toolbar spacing was fixed for NS6. Remaining issues: 1. Top of Attachments field should be even with top of Addressing area. Bottom of Attachments field should be even with bottom of Subject area. 2. Should have the rounded corners on text fields (Subject, Addressing and Attachment fields) like the browser URL field does. (If this is doable)
Comment 20•24 years ago
|
||
marking nsbeta1+ and moving to mozilla0.8
Comment 22•23 years ago
|
||
marking nsbeta1- and moving to future milestone.
Assignee | ||
Comment 23•23 years ago
|
||
Taking bug - for investigation. I may be able to fix this quickly.
Assignee: varada → andreww
Status: ASSIGNED → NEW
Assignee | ||
Comment 24•23 years ago
|
||
Comment 25•23 years ago
|
||
andreww, can you attach a /cvs diff -u/ version of your patch?
Assignee | ||
Comment 26•23 years ago
|
||
Assignee | ||
Comment 27•23 years ago
|
||
ok, I posted the other kind of diff.
Comment 28•23 years ago
|
||
um, it looks like the file was using 2 spaces for indentation, and i think you switched to tabs [or something similarly bad] please replace w/ 2spaces before committing value="..." <- should probably be in a dtd style="height: 0px; width: 0px;" <- i know you didn't do this, but it looks wrong. - </toolbar> + </toolbar> ^please don't add trailing whitespace. otherwise things look ok. [if i get around to it, i'll test]
Comment 29•23 years ago
|
||
See 68480 for lots of related messenger compose UI changes that will land soon
Assignee | ||
Comment 30•23 years ago
|
||
argh - I should look more closely at the code I'm copy/pasting. Thanks for the comments. Ill make those changes and post another patch.
Assignee | ||
Comment 31•23 years ago
|
||
Assignee | ||
Comment 32•23 years ago
|
||
Assignee | ||
Comment 33•23 years ago
|
||
Assignee | ||
Comment 34•23 years ago
|
||
OK I think this is ready for review. Any takers?
Keywords: review
Comment 35•23 years ago
|
||
r=timeless for id=27185, 27186, 27187 but please fix the indentation for: + <text class="label" id="attachmentBucketText" value="&attachments.label;" crop="right" accesskey="&attachments.accesskey;"/> thanks.
Reporter | ||
Comment 36•23 years ago
|
||
Andrew, I noticed Joe changed the "To" widget (looks more like 4.x widget) when he fixed the vertical spacing of the addressing area. Was that on purpose?
Reporter | ||
Comment 37•23 years ago
|
||
Assignee | ||
Comment 38•23 years ago
|
||
I'd say file a separate bug on that and assign it to Joe Hewitt. If that's his intention, he'll mark it invalid or talk with you about it. (Most likely the latter)
Is this ready for super-review? Combined with the new skin, this would be great for mail/news.
Comment 40•23 years ago
|
||
CC sspitzer for super-review. Two and a half month without sr= is quite much. :)
Updated•23 years ago
|
QA Contact: nbaca → olgam
Assignee | ||
Comment 41•23 years ago
|
||
I'm sure these files have bitrotted quite alot. Most if not all the issues listed in this bug have been resolved. Closing out bug and filing a new on on the specific issue of the attachment field alignment. Otherwise these issues will sit here in limbo forever :)
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Comment 42•23 years ago
|
||
So, where is another bug for leftover issues, Andrew? I can not verify this one without seeing new one.
Reporter | ||
Comment 43•22 years ago
|
||
The only issue from this bug that is still valid anymore is: 1. Top of Attachments field should be even with top of Addressing area. Bottom of Attachments field should be even with bottom of Subject area. Andrew filed 114804 for that.
Comment 44•22 years ago
|
||
Verified on Win2K, Linux, Mac OSX - trunk build 02-04-2002. Remaining - in bug 114804.
Status: RESOLVED → VERIFIED
Updated•20 years ago
|
Product: MailNews → Core
Comment 45•19 years ago
|
||
*** Bug 310345 has been marked as a duplicate of this bug. ***
Updated•16 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•