255769 - Organize Hotkeys in task oriented categories

Status: RESOLVED FIXED

Description

[Percy Cabello]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a3) Gecko/20040813 Firefox/0.9.1+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a3) Gecko/20040813 Firefox/0.9.1+

Hotkeys list is too long an unorganized and makes it hard to find a useful hotkey.

Reproducible: Always
Steps to Reproduce:
1. Open the hotkeys page in help
2.
3.

Actual Results:  
A long list of hotkeys

Expected Results:  
An organized list of hotkeys

Comment 1

[Percy Cabello]

Created attachment 156263 [details]
proposed organization.
I included hotkeys for the search bar

Comment 2

[R.J. Keller]

Confirming bug. Lets do this after 1.0.

Comment 3

[R.J. Keller]

Moving to new Firefox Help owner.

Comment 4

[Jeff Walden (gone starting June 8)]

This is worth considering for 1.1, particularly as it would just be
reorganization of line groups.

Comment 5

[zmanji]

I'll take a stab at this. A patch will come soon

Comment 6

[zmanji]

Created attachment 178620 [details] [diff] [review]
quick patch v1

this is a quick patch I through together. It probably needs some minor editing.
Can some one take a look at it?(Jeff?)

Comment 7

[Jeff Walden (gone starting June 8)]

Comment on attachment 178620 [details] [diff] [review]
quick patch v1

The proper way we'll want to split this up is like so (because it's more
semantically valid):

<table border="1" width="100%">
  <thead>
    <tr>
      <th>Command</th>
      <th>&brandShortName;</th>
      <th>Internet Explorer</th>
      <th>Opera</th>
    </tr>
  </thead>
  <tbody>
    <tr>
      <th colspan="4">Categorization Foo</th>
    </tr>
    <tr>
      <td>Add Bookmark</td>
      <td>&accelKey;+<kbd>D</kbd></td>
      <td>&accelKey;+<kbd>D</kbd></td>
      <td>&accelKey;+<kbd>T</kbd></td>
    </tr>
    <tr>
      <th colspan="4">Categorization Bar</th>
    </tr>
    <tr>
      <td>Something</td>
      <td>shortcut</td>
      <td>shortcut</td>
      <td>shortcut</td>
    </tr>
  </tbody>
</table>

Beyond that, I need to look at the proposed categorization a bit more first. 
Some of the categorizations are correct and obvious, but some of the ones in
the first attachment seem to be just a bit too general or buzzword-y.  This'll
have to wait a bit until we come up with a definitive list of categories.

Comment 8

[Jeff Walden (gone starting June 8)]

Created attachment 183010 [details]
Possible org. scheme, feedback wanted

I need feedback here.  I like some of what I've got, but I don't like all of
it.  In particular I very, very much want to avoid having a Miscellaneous
category if at all possible.

Comment 9

[zmanji]

>Miscellaneous:
>Complete .com Address
>Complete .net Address
>Complete .org Address
>Delete Selected Autocomplete Entry

Can't the "Complete" turn into Autocomplete?
Then we can move the above into an Autocomplete catagory or soething similar.   

Comment 10

[Jeff Walden (gone starting June 8)]

(In reply to comment #9)
> Can't the "Complete" turn into Autocomplete?
> Then we can move the above into an Autocomplete catagory or soething similar.  

Adding "Auto" seems like a worthwhile change, but at least to me an Autocomplete
category seems a good deal too specific.  This would also make the Misc.
category unusually small, and if we're making a category that small I'd rather
see it removed.  I also can't think of other items with which to augment an
Autocomplete category, and I think a baseline of at least five items per
category is at least a reasonable (tho if need be, breakable) goal.

Also, while I'm thinking about it, we may want to change "Delete Selected
Autocomplete Entry" to something like "Delete Saved Form Entry" (assuming that's
clear enough) because Shift+Del applies to all form elements with saved entries.

Comment 11

[Steffen Wilberg]

"Complete .com Address" etc. just adds e.g. ".com". That has nothing to do with
autocomplete, which offers previously entered information based on the first
characters the user entered.

Shift-Del also works in the location bar and the search bar, and I wouldn't call
these "forms".

I'm not too concerned about the misc category. I'd put Text Size
Increase/Decrease/Restore next to each other. The last proposal looks pretty
good otherwise.

Comment 12

[zmanji]

sorry for bug spamming, but for whoever does this bug, try to help fix bug
247595 too.(by using entities)

Comment 13

[Jeff Walden (gone starting June 8)]

Created attachment 183969 [details] [diff] [review]
Rearrange things, more or less as described previously

I moved New Message into the Miscellaneous category.  It wasn't in the previous
list because I made the previous list in Linux, whereas to create the patch I
created the categories and then started moving shortcuts into categories one by
one.  I ended up with New Message, which didn't quite seem tool-like to me and
thus got put in Miscellaneous.

Because things are moved around so much, reading the patch doesn't do a whole
lot of good; applying and testing it are probably the only way to really
evaluate it.

One last: the styling of this table currently looks really horrible.  After
this is fixed I'm going to file a bug to get something better-looking here,
because this bluish color is truly ugly.

Comment 14

[Steffen Wilberg]

Comment on attachment 183969 [details] [diff] [review]
Rearrange things, more or less as described previously

Nice! The content, that is. The location of "New Message" as fine as well.

But please do file the bug on improving the style, ugh :)

Comment 15

[Jeff Walden (gone starting June 8)]

Patch checked in, and bug 295229 filed for the styling issues.