25583 - crash sending message if mail/news window is closed

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P1)

Description

[Dan M]

A crash that affects only compulsive neatnicks. But somehow it found me.

Open messenger window. Punch "new message" button. Close messenger window. Type, 
type, type. Punch "send" button in new message. Mozilla visits its ancestors in 
this order:

nsMsgStatusFeedback::setAttribute(nsIWebShell * 0x027f7290, const char * 
0x019e9e20, const char * 0x019e9e18, const nsString & {...}) line 349 + 39 bytes
nsMsgStatusFeedback::ShowStatusString(nsMsgStatusFeedback * const 0x02a621b0, 
const unsigned short * 0x03221030) line 222
nsSmtpProtocol::UpdateStatusWithString(unsigned short * 0x03221030) line 406
nsSmtpProtocol::UpdateStatus(int 5583081) line 398
nsSmtpProtocol::SendDataResponse() line 1077
nsSmtpProtocol::ProcessProtocolState(nsIURI * 0x03234784, nsIInputStream * 
0x032356d8, unsigned int 245, unsigned int 44) line 1356 + 8 bytes
nsMsgProtocol::OnDataAvailable(nsMsgProtocol * const 0x03235c70, nsIChannel * 
0x03235a44, nsISupports * 0x03234784, nsIInputStream * 0x032356d8, unsigned int 
245, unsigned int 44) line 172 + 32 bytes

The crash line is
  rv = shell ? shell->GetContentViewer(getter_AddRefs(cv))

where shell is nonzero, but points to a deleted object.

Apologies if this is a dupe. I couldn't find one in a short search.

Comment 1

[Phil Peterson]

Reassign to mscott, cc jefft. M14

Comment 2

[Scott MacGregor]

Ugghh...this sucks....we are showing status information in the mailnews window
about sending the message...but the message window has been closed behind us..

*sigh*

Comment 3

[jefft]

Yup....

Comment 4

[leger]

Putting on on PDT+ radar for beta1.

Comment 5

[leger]

Adding "crash" keyword.

Comment 6

[Scott MacGregor]

*** Bug 26467 has been marked as a duplicate of this bug. ***

Comment 7

[Scott MacGregor]

I thought this fix was going to be easy by just detecting that the window had
been closed. However, after I did this I ran into more problems. We crash later
on while attempting to add the sent message to your sent folder. Why? because
our data sources associated with the window are being leaked.

All of these problems are due to the fact that so many of our objects whose
lifetime is bound to the mail 3-pane xul window are being leaked. I'm trying to
track down the cause of that now. However, the ref counting logs all point at
xpconnect as the source of the leak. But we know that can't be it. =)

Comment 8

[Scott MacGregor]

I checked in a fix for this. When the msg 3 pane gets unloaded, I mark the
status feedback object as closed so it won't try to set attributes on a webshell
that is no longer there.

Comment 9

[esther]

Using mozilla build 2000-02-16m14 on win98 and commercial builds 2000-02-16-08 
on mac and linux this is fixed.  Verified