255872 - typo in browser/locales/Makefile.in

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Wolfgang Rosenauer [:wolfiR]]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a3) Gecko/20040817
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a3) Gecko/20040817

there is a missing slash in browser/locale/Makefile.in which cause a build error 
with current Aviary_1_0_*_branch

Reproducible: Always
Steps to Reproduce:
.

Comment 1

[Wolfgang Rosenauer [:wolfiR]]

Attachment: add missing slash

Comment 2

[Wolfgang Rosenauer [:wolfiR]]

OK, it's no build error but an install error ;-)

Comment 3

[Ryan Polk (Quark)]

Comment on attachment 156335 [details] [diff] [review]
add missing slash

FYI, you should request review from someone in particular.  Asking bsmedberg
b/c he's done most of this localization stuff.

Comment 4

[Ryan Polk (Quark)]

I don't know much about Makefiles, but looking at the
mozilla/browser/locales/Makefile.in it does seem like line 86 is inconsistent.

Comment 5

[Wolfgang Rosenauer [:wolfiR]]

Ryan, you're right that a particular reviewer should be set. 
The problem is, that I simply don't know whom to ask :-(

Comment 6

[Wolfgang Rosenauer [:wolfiR]]

found another bug in the same Makefile.
searchplugin installation doesn't work

Comment 7

[Wolfgang Rosenauer [:wolfiR]]

Attachment: same patch with another bugfix

this patch contains the first bugfix and the new for searchplugin installation

Comment 8

[Benjamin Smedberg]

Fixed on the branch

Comment 9

[Mike Hommey [:glandium]]

*** Bug 255775 has been marked as a duplicate of this bug. ***

Comment 10

[Asa Dotzler [:asa]]

Comment on attachment 156406 [details] [diff] [review]
same patch with another bugfix

please don't request approval until you have a fully reviewed patch. thanks.