256071 - TB09 crash [@ nsImapProtocol::ReleaseUrlState]

Status: RESOLVED FIXED

(MailNews Core :: Networking: IMAP, defect)

Description

[Jay Patel [:jay]]

This is currently a topcrasher with Thunderbird 0.7.3 and also was a topcrasher
in previous TB07x releases.

Thunderbird 0.7.2 crashes:
http://talkback-public.mozilla.org/talkback/fastfind.jsp?search=1&searchby=stacksig&match=contains&searchfor=+nsImapProtocol%3A%3AReleaseUrlState&vendor=All&product=All&platform=All&buildid=20040707&sdate=&stime=&edate=&etime=

Thunderbird 0.7.3 crashes:
http://talkback-public.mozilla.org/talkback/fastfind.jsp?search=1&searchby=stacksig&match=contains&searchfor=+nsImapProtocol%3A%3AReleaseUrlState&vendor=All&product=All&platform=All&buildid=20040803&sdate=&stime=&edate=&etime=

And the latest Talkback data snapshot for TB073:

Count   Offset    Real Signature
[ 46   nsImapProtocol::ReleaseUrlState 38893817 - nsImapProtocol::ReleaseUrlState ]
 
     Crash date range: 08-AUG-04 to 16-AUG-04
     Min/Max Seconds since last crash: 12 - 912325
     Min/Max Runtime: 3654 - 912325
 
     Count   Platform List 
     33   Windows XP [Windows NT 5.1 build 2600] 
     12   Windows 2K [Windows NT 5.0 build 2195] 
     1   Windows XP [Windows NT 5.2 build 3790] 
 
     Count   Build Id List 
     46   2004080301
 
     No of Unique Users        30
 
 Stack trace(Frame) 

	 nsImapProtocol::ReleaseUrlState
[e:/builds/tbird-0.7.3/WINNT_5.0_Clobber/mozilla/mailnews/imap/src/nsImapProtocol.cpp
 line 900] 
	 nsImapProtocol::ProcessCurrentURL
[e:/builds/tbird-0.7.3/WINNT_5.0_Clobber/mozilla/mailnews/imap/src/nsImapProtocol.cpp
 line 1422] 
	 nsImapProtocol::ImapThreadMainLoop
[e:/builds/tbird-0.7.3/WINNT_5.0_Clobber/mozilla/mailnews/imap/src/nsImapProtocol.cpp
 line 1166]  
 
     (577223)	Comments: I use Thunderbird for IMAP (every 1 minute check) and
NNTP (4 Server 10 minutes check). Thunderbird was idle (minimized) for 30-60
Minutes.
     (573534)	Comments: Thunderbird Error on displaying incoming message
information at taskbar!
     (568159)	Comments: I use Thunderbird for IMAP (every 1 minute check) and
NNTP (4 Server 10 minutes check). 
     (567023)	Comments: checking mail
     (566376)	Comments: I use Thunderbird for IMAP (every 1 minute check) and
NNTP (4 Server 10 minutes check). Thunderbird was idle (minimized) for 30-60
Minutes.
     (560981)	Comments: Loading the program  after it automatically checked email
     (545276)	Comments: Happened over night while the machine was unattended.
     (537973)	Comments: I use Thunderbird for IMAP (every 1 minute check) and
NNTP (4 Server 10 minutes check). Thunderbird was active at crashtime.
     (517649)	Comments: Thunderbird was minimised  although probably still
connect to the IMAP server.
     (516773)	Comments: Failed when my computer was locked and not being used.

Comment 1

[Jay Patel [:jay]]

Still around in Thunderbird 0.9:

Count   Offset    Real Signature
[ 92   nsImapProtocol::ReleaseUrlState 38893817 - nsImapProtocol::ReleaseUrlState ]
 
     Crash date range: 04-NOV-04 to 14-NOV-04
     Min/Max Seconds since last crash: 23 - 477840
     Min/Max Runtime: 32 - 477840
 
     Count   Platform List 
     66   Windows XP [Windows NT 5.1 build 2600] 
     24   Windows 2K [Windows NT 5.0 build 2195] 
     2   Windows XP [Windows NT 5.2 build 3790] 
 
     Count   Build Id List 
     92   2004110312
 
     No of Unique Users        60
 
 Stack trace(Frame) 

	 nsImapProtocol::ReleaseUrlState
[e:/builds/tinderbox/thunderbird-branch/WINNT_5.0_Clobber/mozilla/mailnews/imap/src/nsImapProtocol.cpp
 line 914] 
	 nsImapProtocol::ProcessCurrentURL
[e:/builds/tinderbox/thunderbird-branch/WINNT_5.0_Clobber/mozilla/mailnews/imap/src/nsImapProtocol.cpp
 line 1437] 
	 nsImapProtocol::ImapThreadMainLoop
[e:/builds/tinderbox/thunderbird-branch/WINNT_5.0_Clobber/mozilla/mailnews/imap/src/nsImapProtocol.cpp
 line 1175]  
 
     (1956365)	Comments: Browsing mail folders
     (1939598)	Comments: nothing in particular: computer was just standing by
     (1903941)	Comments: Moving two folders of messages from one IMAP account to
another.
     (1899356)	Comments: Wasn't doing anything. Thunderbird was running in the
background. Have one SSL-IMAP connection  one news connection (gmane) and two
RSS feeds:  http://www.marktplaats.nl/markt/hardware/monitoren.xml  and 
http://planet.jabber.org/rss20.xml    Thunderbird
     (1899356)	Comments:  started up normally after the crash.
     (1898091)	Comments: it was just starting up
     (1880901)	Comments: I did nothing.
     (1880696)	Comments: I use Thunderbird for IMAP (every 1 minute check) and
NNTP (4 Server 10 minutes check). Thunderbird was idle (minimized) for 30-60
Minutes.
     (1878210)	Comments: The Feedback tool opened and that appears to have
caused Thunderbird to crash.
     (1875008)	Comments: Viewing an e-mail with 2 jpg's being displayed inline.
     (1851351)	Comments: Typing an email
     (1832270)	Comments: Runnung overnight checking every 2 minutes for new
mail.  Connecting to corporate MS Exchange server usinf IMAP protocol. 
     (1803743)	Comments: created new filter and executet it.
     (1760951)	Comments: variuos tabs open
     (1752057)	Comments: Thunderbird was running in the background but I was not
using it when it crashed.  
 

Comment 2

[mjc]

This crash is happening to me one or two times a day, using 0.9+ (20041110) on W2K.

The two most recent talkbacks are TB2013495K and TB1992390K.

Comment 3

[David :Bienvenu]

Attachment: possible fix

if we're crashing because the folder sink is null, saving off a copy inside the
monitor protected code should prevent the crash...

Comment 4

[Jay Patel [:jay]]

Nominating for aviary1.0 for null check fix.  Looks like mscott already sr+'d
this, so just making sure we get it in.

Comment 5

[David :Bienvenu]

patch checked into 1.0 branch, we'll see if it fixes the crash...

Comment 6

[Asa Dotzler [:asa]]

Comment on attachment 166295 [details] [diff] [review]
possible fix

a=asa for checkin to 1.8a5

Comment 7

[Asa Dotzler [:asa]]

So far so good. We were getting a crash every other day or so before the patch
and none have shown up since the fix.