256104 - Need element IDs in viewSource.xul

Status: RESOLVED FIXED

(Toolkit :: View Source, defect)

Description

[Eyal Rozenberg]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a2) Gecko/20040714
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a2) Gecko/20040714

The view menu in viewSource.xul has no ID, the menupopus in the view and edit
menus have no id, etc. etc., so it's very hard to overlay this XUL file, since
bug 253147 is not resolved (i.e. one can't insert elements into elements without
ids). Actually this problem of 'element anonymity' prevails in a lot of XUL
files, not just this one; yet, this is the one I want to overlay at the moment :-)

Reproducible: Always
Steps to Reproduce:

Comment 1

[R.J. Keller]

Bug confirmed. I'll post a patch soon.

Comment 2

[R.J. Keller]

Attachment: Patch - adds IDs to viewSource and viewPartialSource

Comment 3

[(not currently active) Ted Mielczarek]

Related: bug 170243 (this could block it, i guess)

Comment 4

[R.J. Keller]

Attachment: oops, forgot viewPartialSource :)

Comment 5

[R.J. Keller]

Fix checked in on the trunk.

Comment 6

[Asa Dotzler [:asa]]

Comment on attachment 156518 [details] [diff] [review]
oops, forgot viewPartialSource :)

a=asa for branch checkin.

Comment 7

[Asa Dotzler [:asa]]

Comment on attachment 156518 [details] [diff] [review]
oops, forgot viewPartialSource :)

need re-approval now that we're past 1.0 RC. setting back to request.

Comment 8

[Asa Dotzler [:asa]]

Comment on attachment 156518 [details] [diff] [review]
oops, forgot viewPartialSource :)

too late for 1.0

Comment 9

[Jeff Walden (gone starting June 8)]

Ben overwrote this and it needs to be relanded.

Comment 10

[R.J. Keller]

Fix checked in.