Closed
Bug 256172
Opened 20 years ago
Closed 20 years ago
Favicons not loaded when "Load Images" "for the originating Web site only" selected
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
People
(Reporter: hub-san, Assigned: mvl)
References
()
Details
Attachments
(2 files)
1.15 KB,
patch
|
shaver
:
superreview+
|
Details | Diff | Splinter Review |
1.38 KB,
patch
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8a3) Gecko/20040817 Firefox/0.9.1+ Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8a3) Gecko/20040817 Firefox/0.9.1+ When I select both "Load Images" and "for the originating Web site only" from "Web Features", favicons are not loaded in both location bar and tab. In this setting, Favicons should be loaded. But, favicons are not loaded on Firefox and Mozilla suite. Reproducible: Always Steps to Reproduce: 1. Goto Firefox->Preferences...->Advanced. Uncheck "Hide the tab bar when only one website is open." 2. Goto Web Features. Check both "Load Images" and "for the originating Web site only". Select OK button. 3. Quit and restart. 4. Visit the URL (http://www.mozilla.org/). 5. Favicons are not loaded in both location bar and tab. Actual Results: When I select both "Load Images" and "for the originating Web site only", favicons are not loaded. But, uncheck "for the originating Web site only", favicons are loaded. Expected Results: When I select both "Load Images" and "for the originating Web site only", favicons should be loaded. I confirm this problem on 2004-08-05-09-trunk Firefox build(MacOSX10.2.8). Then, 2004-08-17-09-trunk still have this problem. But, 2004-08-04-09-trunk didn't have this problem. And I confirm this problem on 2004-08-05-12-trunk Firefox build(Linux gtk2+xft). It seemed that this regression occurred between 20040804 and 20040805.
Comment 1•20 years ago
|
||
Please reopen this bug if y ou dont agree that this is a duplicate. *** This bug has been marked as a duplicate of 253238 ***
Status: UNCONFIRMED → RESOLVED
Closed: 20 years ago
Resolution: --- → DUPLICATE
Reopen this bug because I confirmed that this bug was regression by bug 253627. I got the source of mozilla-2004-08-04-07-trunk and mozilla-2004-08-06-07-trunk. The source of 2004-08-04-07-trunk was not changed by bug 253627. Then, I restored the files which was changed by bug 253627 in the source of 2004-08-06-07-trunk. And I made gtk2+xft build which is based on the restored source of 2004-08-06-07-trunk on Linux(RedHat/Fedora). Using this build(Mozilla gtk2+xft), favicon is loaded when "Accept image that come from originating server only" is selected. But, Using 2004-08-06-03-trunk of official gtk2+xft build, favicon is not loaded when "Accept image that come from originating server only" is selected. It is obvious that this problem is regression by fixed bug 253627 as described above. Folks, Is bug 253238 related to bug 253627(or bug 236889)?
Status: RESOLVED → UNCONFIRMED
Resolution: DUPLICATE → ---
Comment 3•20 years ago
|
||
All that happened in bug 253627 is that we started actually doing a security check that we were not doing before. If that check is failing when it should not, then either the caller is not passing in the right info or the wallet code is blocking things it should not (for example, the same-origin check should probably allow chrome to load things from any site).
Assignee | ||
Comment 4•20 years ago
|
||
The patch make third-party checks always allow chrome: as requesting url.
Assignee | ||
Updated•20 years ago
|
Assignee: firefox → mvl
Status: UNCONFIRMED → ASSIGNED
Assignee | ||
Updated•20 years ago
|
Attachment #157503 -
Flags: superreview?(shaver)
Attachment #157503 -
Flags: review?(dwitte)
Comment on attachment 157503 [details] [diff] [review] patch v1 Good-looking polish fix for aviary?
Attachment #157503 -
Flags: superreview?(shaver)
Attachment #157503 -
Flags: superreview+
Attachment #157503 -
Flags: approval-aviary?
Comment 6•20 years ago
|
||
You may want to check for resource: too...
I made gtk2+xft build which was based on the patched source of 2004-08-31-07-trunk. Using this build, favicon is loaded when "Accept images that come from the originating server only" is selected. It seems that the patch works fine. I change Firefox into Browser at the status of product because this patch should be applied to both Mozilla suite and Firefox.
Component: General → Image Blocking
Product: Firefox → Browser
Version: unspecified → Trunk
Comment 8•20 years ago
|
||
Comment on attachment 157503 [details] [diff] [review] patch v1 a=asa for branch checkin.
Attachment #157503 -
Flags: approval-aviary? → approval-aviary+
Comment 9•20 years ago
|
||
Comment on attachment 157503 [details] [diff] [review] patch v1 approval 1.7x if applicable
Attachment #157503 -
Flags: approval1.7.x+
Updated•20 years ago
|
Attachment #157503 -
Flags: review+
Assignee | ||
Comment 10•20 years ago
|
||
checked in (including resources: check)
Status: ASSIGNED → RESOLVED
Closed: 20 years ago → 20 years ago
Resolution: --- → FIXED
Can someone explain why minor fixes like this are still being landed on Aviary/1.7?
Especially because this is a fix for a regression that, as far as I can tell from Bugzilla, has never existed on those branches?
OK, it turns out that bug 253627 did land on Aviary, there's just no Bugzilla record of its approval and landing. Nor can I see why it needed to land, although that may be just because no-one bothered to mention it. Sigh. Fine, go ahead here.
Correct, this did not land on Aviary. I was right the first time. This is a fix for a regression that was never on the branches. So, clearing approvals.
Attachment #157503 -
Flags: approval1.7.x+
Attachment #157503 -
Flags: approval-aviary+
> Correct
"Correction"
Assignee | ||
Updated•20 years ago
|
Component: Image Blocking → General
Product: Browser → Firefox
Assignee | ||
Comment 16•20 years ago
|
||
Comment on attachment 157503 [details] [diff] [review] patch v1 Can only remove the obsolete flag in the product where it was set. sorry for the spam.
Attachment #157503 -
Flags: review?(dwitte)
Reporter | ||
Comment 17•20 years ago
|
||
Reopen this bug. I confirmed this bug on 2005-01-03-06-trunk of Mozilla suite (MacOSX10.2.8). 2004-12-16-06-trunk already had this bug. But, 2004-12-15-06-trunk didn't have this bug. This regression occurred between 20041215 and 20041216. It seemed that this regression was caused by bug 240070. Checkin range is roughly: http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2004-12-15+06%3A00&maxdate=2004-12-16+06%3A00&cvsroot=%2Fcvsroot
Status: RESOLVED → UNCONFIRMED
Resolution: FIXED → ---
Comment 18•20 years ago
|
||
confirming - allowing images "for the originating web site only" breaks favicons, using a 31st December Firefox trunk build on Win2000.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: Favicons are not loaded when I select both "Load Images" and "for the originating Web site only". → Favicons not loaded when "Load Images" "for the originating Web site only" selected
Assignee | ||
Comment 19•20 years ago
|
||
attachment 157503 [details] [diff] [review] ported to permission extension
Reporter | ||
Comment 20•20 years ago
|
||
I made mozilla-gtk2+xft build which was based on the patched source of 2005-01-13-05-trunk(on Fedora Core 3). Using this build, favicon loaded when "Accept images that come from the originating server only" selected. It seems that the patch(attachment 171127 [details] [diff] [review]) fixed this bug. But, initial setting of "Image Acceptance Policy" still breaks. Before 2004-12-15-06-trunk, radio button of "Accept all images" was selected at "Image Acceptance Policy" by default. I sent no reports about it because "patch v1"(attachment 157503 [details] [diff] [review]) fixed the problem of initial setting on Sep. 2004. I have reported about it as bug 279782.
Assignee | ||
Comment 21•20 years ago
|
||
patch checked in.
Status: NEW → RESOLVED
Closed: 20 years ago → 20 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•