NS_NewAtom(const PRUnichar* us) doesn't check result of new

RESOLVED FIXED in M15

Status

()

Core
XPCOM
P3
normal
RESOLVED FIXED
19 years ago
19 years ago

People

(Reporter: Patrick C. Beard, Assigned: Scott Collins)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

(Reporter)

Description

19 years ago
Running with the Boehm collector, it's possible to exhaust memory, so I had a low 
memory condition that causes the line of code in the CVS blame URL above to 
crash. This code should be more defensive.

Updated

19 years ago
Assignee: troy → dp
Component: Layout → XPCOM
QA Contact: petersen → dp

Comment 1

19 years ago
CHanging component and re-assigning

Comment 2

19 years ago
Scott could you do the honors.
Assignee: dp → scc
(Assignee)

Updated

19 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 3

19 years ago
Fixed
Status: ASSIGNED → RESOLVED
Last Resolved: 19 years ago
Resolution: --- → FIXED
(Reporter)

Comment 4

19 years ago
Your fix still adds a potentially NULL atom to the hashtable. And it dereferences 
id->mString.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 5

19 years ago
Marking M15, but I hope to get the fix in before then, since it should be quick.  
It's just too rare a case to let it actually interfere with potential beta-
blockers.
Target Milestone: M15
(Assignee)

Comment 6

19 years ago
FIXED in "nsAtomTable.cpp" 3.21
Status: REOPENED → RESOLVED
Last Resolved: 19 years ago19 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.